Round off error while calculating the background-size: contain/cover.

Round off error while calculating the background-size: contain/cover.

While calculating the height and width of a background image for container
with the background-size: contain/cover, on some platforms 
these values(height and width) are not properly rounded off. Converting
these values to integer always takes the floor value rather than rounding it
off.

BUG=257402
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158044

[eseidel, 2013-09-18 18:59:17]

This feels very related to https://codereview.chromium.org/24066007/

[eseidel, 2013-09-18 18:59:44]

https://codereview.chromium.org/23788011/diff/1/Source/core/rendering/RenderB...
File Source/core/rendering/RenderBoxModelObject.cpp (right):

https://codereview.chromium.org/23788011/diff/1/Source/core/rendering/RenderB...
Source/core/rendering/RenderBoxModelObject.cpp:937: return IntSize(max(1,
static_cast<int>(round(imageIntrinsicSize.width() * scaleFactor))), max(1,
static_cast<int>(round(imageIntrinsicSize.height() * scaleFactor))));
should this just be lround?

[pravind, 2013-09-18 19:35:55]

On 2013/09/18 18:59:44, eseidel wrote:
>
https://codereview.chromium.org/23788011/diff/1/Source/core/rendering/RenderB...
> File Source/core/rendering/RenderBoxModelObject.cpp (right):
> 
>
https://codereview.chromium.org/23788011/diff/1/Source/core/rendering/RenderB...
> Source/core/rendering/RenderBoxModelObject.cpp:937: return IntSize(max(1,
> static_cast<int>(round(imageIntrinsicSize.width() * scaleFactor))), max(1,
> static_cast<int>(round(imageIntrinsicSize.height() * scaleFactor))));
> should this just be lround?
> 

Have uploaded another patch that uses lround(). Removed static casting to int in
max().

[eseidel, 2013-09-18 19:56:49]

lgtm

[commit-bot: I haz the power, 2013-09-18 20:15:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pravin.d@samsung.com/23788011/7001

[commit-bot: I haz the power, 2013-09-18 21:55:03]

Retried try job too often on linux_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2013-09-19 17:43:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pravin.d@samsung.com/23788011/22001

[commit-bot: I haz the power, 2013-09-19 17:43:58]

Failed to apply patch for LayoutTests/TestExpectations:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file LayoutTests/TestExpectations
  Hunk #1 FAILED at 1278.
  1 out of 1 hunk FAILED -- saving rejects to file
LayoutTests/TestExpectations.rej

Patch:       LayoutTests/TestExpectations
Index: LayoutTests/TestExpectations
diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
index
a6cba6783cdcb7616dbd1f97aa71016c8b0774db..2911fb3ef302f369d5236537fd45ec2a63448925
100644
--- a/LayoutTests/TestExpectations
+++ b/LayoutTests/TestExpectations
@@ -1278,3 +1278,7 @@ crbug.com/276769
http/tests/security/contentSecurityPolicy/source-list-parsing-n
 crbug.com/286081 inspector/debugger/long-resume-vs-reload.html [ Failure Pass
Timeout ]
 crbug.com/285703 [ Debug ]
fast/table/table-rowspan-crash-with-huge-rowspan-cells.html [ Crash Pass ]
 crbug.com/286287 http/tests/inspector/network/network-initiator.html [ Failure
Pass ]
+
+#Below test cases need to be rebaseline after crbug.com/269500
+crbug.com/269500 fast/backgrounds/size/contain-and-cover-zoomed.html [
NeedsRebaseline ]
+crbug.com/269500 fast/backgrounds/size/contain-and-cover.html [ NeedsRebaseline
]

[commit-bot: I haz the power, 2013-09-19 18:03:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pravin.d@samsung.com/23788011/28001

[commit-bot: I haz the power, 2013-09-19 19:02:08]

Change committed as 158044