Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: Source/bindings/v8/V8PerContextData.cpp

Issue 23788005: Remove calls to HandleScope default ctor. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/V8PerContextData.cpp
diff --git a/Source/bindings/v8/V8PerContextData.cpp b/Source/bindings/v8/V8PerContextData.cpp
index 6846eafb17a7a5e8b3a0b0182b34fb09a384ac2c..326aef16623d1eac26f6fed50d9d089cfc1d0aad 100644
--- a/Source/bindings/v8/V8PerContextData.cpp
+++ b/Source/bindings/v8/V8PerContextData.cpp
@@ -190,7 +190,7 @@ bool V8PerContextDebugData::setContextDebugData(v8::Handle<v8::Context> context,
{
if (!debugData(context)->IsUndefined())
return false;
- v8::HandleScope scope;
+ v8::HandleScope scope(context->GetIsolate());
v8::Handle<v8::Value> debugData = createDebugData(worldName, debugId);
setDebugData(context, debugData);
return true;
@@ -198,7 +198,7 @@ bool V8PerContextDebugData::setContextDebugData(v8::Handle<v8::Context> context,
int V8PerContextDebugData::contextDebugId(v8::Handle<v8::Context> context)
{
- v8::HandleScope scope;
+ v8::HandleScope scope(context->GetIsolate());
v8::Handle<v8::Value> data = debugData(context);
if (!data->IsString())

Powered by Google App Engine
This is Rietveld 408576698