Change the default relay port from GTURN to TURN.

Change the default relay port from GTURN to TURN.

While most of our code is using TURN, this constructor is using GTURN
as the default TURN port. And this constructor is only used by tests AFAIK.
We should make the tests more consistent with what we are using in the code.

Do not submit this because it would cause test failures and we should deprecate the usage of this constructor. 

BUG=None

[Taylor Brandstetter, 2016-09-28 23:41:27]

deadbeef@webrtc.org changed reviewers:
+ deadbeef@webrtc.org

[Taylor Brandstetter, 2016-09-28 23:41:28]

lgtm. Also, as long as we're here, we may want to add a TODO to deprecate and
later remove this constructor. It looks like it's only used by tests and
downstream code that passes in empty arguments.

[honghaiz3, 2016-09-29 00:10:01]

On 2016/09/28 23:41:28, Taylor Brandstetter wrote:
> lgtm. Also, as long as we're here, we may want to add a TODO to deprecate and
> later remove this constructor. It looks like it's only used by tests and
> downstream code that passes in empty arguments.
Added TODO.

[honghaiz3, 2016-09-29 00:10:06]

The CQ bit was checked by honghaiz@webrtc.org

[honghaiz3, 2016-09-29 00:10:07]

The patchset sent to the CQ was uploaded after l-g-t-m from deadbeef@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2378793003/#ps20001 (title:
"Add TODO to deprecate the constructor.")

[commit-bot: I haz the power, 2016-09-29 00:10:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-29 00:11:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 00:11:46]

Try jobs failed on following builders:
  linux_arm on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_arm/builds/1587)

[honghaiz3, 2016-09-29 02:50:10]

It turns out that we cannot change the TURN type from GTURN to TURN directly
because TURN config requires setting the credentials while GTURN does not. 
We need to stop using this constructor in tests (and downstream apps), and
deprecate this constructor. 
Will drop this CL.

[honghaiz3, 2016-09-29 17:06:14]

Description was changed from

==========
Change the default relay port from GTURN to TURN.

While most of our code is using TURN, this constructor is using GTURN
as the default TURN port. And this constructor is only used by tests AFAIK.
We should make the tests more consistent with what we are using in the code.

Plus I saw some weird errors on GTURN in tests, which may not be worth debugging
it.

BUG=None
==========

to

==========
Change the default relay port from GTURN to TURN.

While most of our code is using TURN, this constructor is using GTURN
as the default TURN port. And this constructor is only used by tests AFAIK.
We should make the tests more consistent with what we are using in the code.

Do not submit this because it would cause test failures and we should deprecate
the usage of this constructor. 

BUG=None
==========

[honghaiz3, 2016-09-29 17:06:14]

honghaiz@webrtc.org changed reviewers:
- deadbeef@webrtc.org