[WASM] Implements catch for the wasm low level exception mechanism.

[WASM] Implements catch for the wasm low level exception mechanism.

This is essentially CL/2275293002, with the difference that the effect
dependencies are now updated correctly.

BUG=

Committed: https://crrev.com/7ed565b6a5fadcb3b2fe678f7b8411c1fcb0566e
Cr-Commit-Position: refs/heads/master@{#39919}

[John, 2016-09-30 12:45:48]

The CQ bit was checked by jpp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 12:45:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[John, 2016-09-30 12:47:28]

jpp@chromium.org changed reviewers:
+ bradnelson@chromium.org, titzer@chromium.org

[John, 2016-09-30 12:47:29]

This is the only difference between this cl and cl/2275293002:

https://codereview.chromium.org/2378773013/diff2/1:20001/src/compiler/wasm-co...

[commit-bot: I haz the power, 2016-09-30 13:12:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 13:12:56]

Dry run: This issue passed the CQ dry run.

[bradnelson, 2016-09-30 15:30:46]

lgtm

[John, 2016-09-30 15:36:10]

The CQ bit was checked by jpp@chromium.org

[commit-bot: I haz the power, 2016-09-30 15:36:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 15:41:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 15:41:27]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/25456)

[bradnelson, 2016-09-30 15:45:17]

bradnelson@chromium.org changed reviewers:
+ mtrofin@chromium.org

[bradnelson, 2016-09-30 15:45:17]

+mtrofin

Can we get rubberstamp to reland this, with the fix?

[Mircea Trofin, 2016-09-30 15:50:35]

On 2016/09/30 15:45:17, bradnelson wrote:
> +mtrofin
> 
> Can we get rubberstamp to reland this, with the fix?

lgtm, but I have 2 nits.

[Mircea Trofin, 2016-09-30 16:00:44]

https://codereview.chromium.org/2378773013/diff/20001/src/compiler/wasm-compi...
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/2378773013/diff/20001/src/compiler/wasm-compi...
src/compiler/wasm-compiler.cc:1749: Node* is_smi;
it'd be nice if these were initialized and DCHECK-ed on the BuildTestNotSmi,
thus clarifying the contract.

https://codereview.chromium.org/2378773013/diff/20001/test/mjsunit/wasm/excep...
File test/mjsunit/wasm/exceptions.js (right):

https://codereview.chromium.org/2378773013/diff/20001/test/mjsunit/wasm/excep...
test/mjsunit/wasm/exceptions.js:155: //
why is this commented? could you please delete it, if it's not needed?

[John, 2016-09-30 16:07:17]

https://codereview.chromium.org/2378773013/diff/20001/src/compiler/wasm-compi...
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/2378773013/diff/20001/src/compiler/wasm-compi...
src/compiler/wasm-compiler.cc:1749: Node* is_smi;
On 2016/09/30 16:00:44, Mircea Trofin wrote:
> it'd be nice if these were initialized and DCHECK-ed on the BuildTestNotSmi,
> thus clarifying the contract.

I agree, but I'd have to change every call to Branch(); I'll leave as is.

https://codereview.chromium.org/2378773013/diff/20001/test/mjsunit/wasm/excep...
File test/mjsunit/wasm/exceptions.js (right):

https://codereview.chromium.org/2378773013/diff/20001/test/mjsunit/wasm/excep...
test/mjsunit/wasm/exceptions.js:155: //
On 2016/09/30 16:00:44, Mircea Trofin wrote:
> why is this commented? could you please delete it, if it's not needed?

This documents what the test does -- it is pretty hard to decode the wasm code.
I'll leave it.

[John, 2016-09-30 16:07:26]

The CQ bit was checked by jpp@chromium.org

[commit-bot: I haz the power, 2016-09-30 16:07:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 16:09:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-30 16:09:35]

Description was changed from

==========
[WASM] Implements catch for the wasm low level exception mechanism.

This is essentially CL/2275293002, with the difference that the effect
dependencies are now updated correctly.

BUG=
==========

to

==========
[WASM] Implements catch for the wasm low level exception mechanism.

This is essentially CL/2275293002, with the difference that the effect
dependencies are now updated correctly.

BUG=

Committed: https://crrev.com/7ed565b6a5fadcb3b2fe678f7b8411c1fcb0566e
Cr-Commit-Position: refs/heads/master@{#39919}
==========

[commit-bot: I haz the power, 2016-09-30 16:09:36]

Patchset 2 (id:??) landed as
https://crrev.com/7ed565b6a5fadcb3b2fe678f7b8411c1fcb0566e
Cr-Commit-Position: refs/heads/master@{#39919}