Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2378773008:
libyuv: bt.709 coefficients update, halffloat support, mips msa (Closed)
|
Created:
4 years, 2 months ago by fbarchard1 Modified:
4 years, 2 months ago Reviewers:
hubbe CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionlibyuv: bt.709 coefficients update, halffloat support, mips msa
bt.709 coefficients in chrome media at video range, while libyuv
originally implemented full range. This changes libyuv to match
media's video range coefficients for H420ToARGB
HalfFloatPlane function added for converting shorts to half floats
for gpu texture support. Uses intel instruction vcvtps2ph and
provides a C fallback for other processors.
Mips MSA initial SIMD support for new instruction set. MSA provides
16 byte wide registers, vs DSPR2 was 4 bytes. Performance is
approximately 12x vs C versions of I420Mirror and I420ToYUY2.
Change log:
https://chromium.googlesource.com/libyuv/libyuv/+log/de944ed8..7fc932dd
https://chromium.googlesource.com/libyuv/libyuv/+/de944ed8..7fc932dd
BUG=libyuv:560, libyuv:639, chromium:445071, libyuv:635, libyuv:636, libyuv:637, chromium:646279, libyuv:634
TEST=try bots and new unittests added for halffloat.
R=hubbe@chromium.org
Committed: https://crrev.com/1b959ada6e8cb860d4fe25a0aa6fb0a16899b1aa
Cr-Commit-Position: refs/heads/master@{#422132}
Patch Set 1 #Messages
Total messages: 16 (12 generated)
Description was changed from ========== libyuv: bt.709 coefficients update, halffloat support, mips msa bt.709 coefficients in chrome media at video range, while libyuv originally implemented full range. This changes libyuv to match media's video range coefficients for H420ToARGB HalfFloatPlane function added for converting shorts to half floats for gpu texture support. Uses intel instruction vcvtps2ph and provides a C fallback for other processors. Mips MSA initial SIMD support for new instruction set. MSA provides 16 byte wide registers, vs DSPR2 was 4 bytes. Performance is approximately 12x vs C versions of I420Mirror and I420ToYUY2. Change log: https://chromium.googlesource.com/libyuv/libyuv/+log/de944ed8..5da918b4 https://chromium.googlesource.com/libyuv/libyuv/+/de944ed8..5da918b4 BUG=libyuv:560, chromium:445071 TEST=try bots and new unittests added for halffloat. R=hubbe@chromium.org ========== to ========== libyuv: bt.709 coefficients update, halffloat support, mips msa bt.709 coefficients in chrome media at video range, while libyuv originally implemented full range. This changes libyuv to match media's video range coefficients for H420ToARGB HalfFloatPlane function added for converting shorts to half floats for gpu texture support. Uses intel instruction vcvtps2ph and provides a C fallback for other processors. Mips MSA initial SIMD support for new instruction set. MSA provides 16 byte wide registers, vs DSPR2 was 4 bytes. Performance is approximately 12x vs C versions of I420Mirror and I420ToYUY2. Change log: https://chromium.googlesource.com/libyuv/libyuv/+log/5da918b4..7fc932dd https://chromium.googlesource.com/libyuv/libyuv/+/5da918b4..7fc932dd BUG=libyuv:560, chromium:445071 TEST=try bots and new unittests added for halffloat. R=hubbe@chromium.org ==========
Description was changed from ========== libyuv: bt.709 coefficients update, halffloat support, mips msa bt.709 coefficients in chrome media at video range, while libyuv originally implemented full range. This changes libyuv to match media's video range coefficients for H420ToARGB HalfFloatPlane function added for converting shorts to half floats for gpu texture support. Uses intel instruction vcvtps2ph and provides a C fallback for other processors. Mips MSA initial SIMD support for new instruction set. MSA provides 16 byte wide registers, vs DSPR2 was 4 bytes. Performance is approximately 12x vs C versions of I420Mirror and I420ToYUY2. Change log: https://chromium.googlesource.com/libyuv/libyuv/+log/5da918b4..7fc932dd https://chromium.googlesource.com/libyuv/libyuv/+/5da918b4..7fc932dd BUG=libyuv:560, chromium:445071 TEST=try bots and new unittests added for halffloat. R=hubbe@chromium.org ========== to ========== libyuv: bt.709 coefficients update, halffloat support, mips msa bt.709 coefficients in chrome media at video range, while libyuv originally implemented full range. This changes libyuv to match media's video range coefficients for H420ToARGB HalfFloatPlane function added for converting shorts to half floats for gpu texture support. Uses intel instruction vcvtps2ph and provides a C fallback for other processors. Mips MSA initial SIMD support for new instruction set. MSA provides 16 byte wide registers, vs DSPR2 was 4 bytes. Performance is approximately 12x vs C versions of I420Mirror and I420ToYUY2. Change log: https://chromium.googlesource.com/libyuv/libyuv/+log/de944ed8..7fc932dd https://chromium.googlesource.com/libyuv/libyuv/+/de944ed8..7fc932dd BUG=libyuv:560, chromium:445071 TEST=try bots and new unittests added for halffloat. R=hubbe@chromium.org ==========
Description was changed from ========== libyuv: bt.709 coefficients update, halffloat support, mips msa bt.709 coefficients in chrome media at video range, while libyuv originally implemented full range. This changes libyuv to match media's video range coefficients for H420ToARGB HalfFloatPlane function added for converting shorts to half floats for gpu texture support. Uses intel instruction vcvtps2ph and provides a C fallback for other processors. Mips MSA initial SIMD support for new instruction set. MSA provides 16 byte wide registers, vs DSPR2 was 4 bytes. Performance is approximately 12x vs C versions of I420Mirror and I420ToYUY2. Change log: https://chromium.googlesource.com/libyuv/libyuv/+log/de944ed8..7fc932dd https://chromium.googlesource.com/libyuv/libyuv/+/de944ed8..7fc932dd BUG=libyuv:560, chromium:445071 TEST=try bots and new unittests added for halffloat. R=hubbe@chromium.org ========== to ========== libyuv: bt.709 coefficients update, halffloat support, mips msa bt.709 coefficients in chrome media at video range, while libyuv originally implemented full range. This changes libyuv to match media's video range coefficients for H420ToARGB HalfFloatPlane function added for converting shorts to half floats for gpu texture support. Uses intel instruction vcvtps2ph and provides a C fallback for other processors. Mips MSA initial SIMD support for new instruction set. MSA provides 16 byte wide registers, vs DSPR2 was 4 bytes. Performance is approximately 12x vs C versions of I420Mirror and I420ToYUY2. Change log: https://chromium.googlesource.com/libyuv/libyuv/+log/de944ed8..7fc932dd https://chromium.googlesource.com/libyuv/libyuv/+/de944ed8..7fc932dd BUG=libyuv:560, libyuv:639, chromium:445071,libyuv:635, libyuv:636, libyuv:637, chromium:646279, libyuv:634 TEST=try bots and new unittests added for halffloat. R=hubbe@chromium.org ==========
The CQ bit was checked by fbarchard@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was checked by fbarchard@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by fbarchard@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== libyuv: bt.709 coefficients update, halffloat support, mips msa bt.709 coefficients in chrome media at video range, while libyuv originally implemented full range. This changes libyuv to match media's video range coefficients for H420ToARGB HalfFloatPlane function added for converting shorts to half floats for gpu texture support. Uses intel instruction vcvtps2ph and provides a C fallback for other processors. Mips MSA initial SIMD support for new instruction set. MSA provides 16 byte wide registers, vs DSPR2 was 4 bytes. Performance is approximately 12x vs C versions of I420Mirror and I420ToYUY2. Change log: https://chromium.googlesource.com/libyuv/libyuv/+log/de944ed8..7fc932dd https://chromium.googlesource.com/libyuv/libyuv/+/de944ed8..7fc932dd BUG=libyuv:560, libyuv:639, chromium:445071,libyuv:635, libyuv:636, libyuv:637, chromium:646279, libyuv:634 TEST=try bots and new unittests added for halffloat. R=hubbe@chromium.org ========== to ========== libyuv: bt.709 coefficients update, halffloat support, mips msa bt.709 coefficients in chrome media at video range, while libyuv originally implemented full range. This changes libyuv to match media's video range coefficients for H420ToARGB HalfFloatPlane function added for converting shorts to half floats for gpu texture support. Uses intel instruction vcvtps2ph and provides a C fallback for other processors. Mips MSA initial SIMD support for new instruction set. MSA provides 16 byte wide registers, vs DSPR2 was 4 bytes. Performance is approximately 12x vs C versions of I420Mirror and I420ToYUY2. Change log: https://chromium.googlesource.com/libyuv/libyuv/+log/de944ed8..7fc932dd https://chromium.googlesource.com/libyuv/libyuv/+/de944ed8..7fc932dd BUG=libyuv:560, libyuv:639, chromium:445071,libyuv:635, libyuv:636, libyuv:637, chromium:646279, libyuv:634 TEST=try bots and new unittests added for halffloat. R=hubbe@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== libyuv: bt.709 coefficients update, halffloat support, mips msa bt.709 coefficients in chrome media at video range, while libyuv originally implemented full range. This changes libyuv to match media's video range coefficients for H420ToARGB HalfFloatPlane function added for converting shorts to half floats for gpu texture support. Uses intel instruction vcvtps2ph and provides a C fallback for other processors. Mips MSA initial SIMD support for new instruction set. MSA provides 16 byte wide registers, vs DSPR2 was 4 bytes. Performance is approximately 12x vs C versions of I420Mirror and I420ToYUY2. Change log: https://chromium.googlesource.com/libyuv/libyuv/+log/de944ed8..7fc932dd https://chromium.googlesource.com/libyuv/libyuv/+/de944ed8..7fc932dd BUG=libyuv:560, libyuv:639, chromium:445071,libyuv:635, libyuv:636, libyuv:637, chromium:646279, libyuv:634 TEST=try bots and new unittests added for halffloat. R=hubbe@chromium.org ========== to ========== libyuv: bt.709 coefficients update, halffloat support, mips msa bt.709 coefficients in chrome media at video range, while libyuv originally implemented full range. This changes libyuv to match media's video range coefficients for H420ToARGB HalfFloatPlane function added for converting shorts to half floats for gpu texture support. Uses intel instruction vcvtps2ph and provides a C fallback for other processors. Mips MSA initial SIMD support for new instruction set. MSA provides 16 byte wide registers, vs DSPR2 was 4 bytes. Performance is approximately 12x vs C versions of I420Mirror and I420ToYUY2. Change log: https://chromium.googlesource.com/libyuv/libyuv/+log/de944ed8..7fc932dd https://chromium.googlesource.com/libyuv/libyuv/+/de944ed8..7fc932dd BUG=libyuv:560, libyuv:639, chromium:445071,libyuv:635, libyuv:636, libyuv:637, chromium:646279, libyuv:634 TEST=try bots and new unittests added for halffloat. R=hubbe@chromium.org Committed: https://crrev.com/1b959ada6e8cb860d4fe25a0aa6fb0a16899b1aa Cr-Commit-Position: refs/heads/master@{#422132} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/1b959ada6e8cb860d4fe25a0aa6fb0a16899b1aa Cr-Commit-Position: refs/heads/master@{#422132} |
