Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2378773005: [tracing] Fix typo in layer tree view error (Closed)

Created:
4 years, 2 months ago by hjd
Modified:
4 years, 1 month ago
Reviewers:
eakuefner, perezju
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : grr, single quotes not allowed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tracing/tracing/ui/extras/chrome/cc/layer_tree_quad_stack_view.html View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
hjd
ptal, thanks! :)
4 years, 1 month ago (2016-11-04 16:00:59 UTC) #2
perezju
lgtm, but you'll also need a catapult owner. maybe +eakuefner?
4 years, 1 month ago (2016-11-04 16:20:49 UTC) #4
eakuefner
lgtm
4 years, 1 month ago (2016-11-04 17:08:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378773005/1
4 years, 1 month ago (2016-11-04 17:24:20 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Presubmit/builds/5046)
4 years, 1 month ago (2016-11-04 17:26:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378773005/20001
4 years, 1 month ago (2016-11-07 12:14:11 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 12:39:25 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698