Add ability to reuse address in chrome.sockets.udp

extensions/test/data/sockets_udp/api/background.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // net/tools/testserver/testserver.py is picky about the format of what it
 // calls its "echo" messages. One might go so far as to mutter to oneself that
 // it isn't an echo server at all.
 //
 // The response is based on the request but obfuscated using a random key.
 const request = "0100000005320000005hello";
@@ skipping 53 matching lines @@
     chrome.test.assertTrue(createInfo.socketId > 0);
 
     // Obtaining socket information before a connect() call should be safe, but
     // return empty values.
     chrome.sockets.udp.getInfo(createInfo.socketId, onGetInfo);
   }
 
   chrome.sockets.udp.create({}, onCreate);
 };
 
+var testSocketReusable = function() {
+  var address = '224.0.0.251';
+  var port = 5353;
+
+  var numSocketsCreated = 0;
+  var numSocketsExpected = 2;
+
+  var socketIds = [];
+
+  function onCreate(createInfo) {
+    function onBind(result) {
+      chrome.test.assertEq(0, result, 'Bind failed with error: ' + result);
+      chrome.sockets.udp.getInfo(createInfo.socketId, onGetInfoAfterBind);
+    }
+
+    function onGetInfoBeforeBind(info) {

[carlosk, 2016/09/30 02:16:24]

nit: it would be clearer to me if these 3 methods were defined in their logical
order: onGetInfoBeforeBind, onBind and then onGetInfoAfterBind.

[srsudar, 2016/09/30 15:07:17]

Done.

+      if (info.localAddress || info.localPort) {
+        chrome.test.fail('Unconnected socket should not have local binding');
+      }
+
+      chrome.test.assertEq(true, info.addressReusable, 'Should be reusable');
+
+      chrome.sockets.udp.bind(createInfo.socketId, address, port, onBind);
+    }
+
+    function onGetInfoAfterBind(info) {
+      numSocketsCreated += 1;
+      chrome.test.assertEq(address, info.localAddress,
+        'Bound to wrong address');
+      chrome.test.assertEq(port, info.localPort, 'Bound to wrong port');
+      chrome.test.assertEq(true, info.addressReusable, 'Should be reusable');
+
+      if (numSocketsCreated < numSocketsExpected) {
+        // Bind again to ensure the address is reusable.
+        createAndBindToSharedAddress();
+      } else {
+        chrome.test.assertEq(numSocketsCreated, numSocketsExpected,
+          'Not all sockets created during test');

[carlosk, 2016/09/30 02:16:24]

Is this trying to check if too many sockets were created? I am assuming that is
true because this code would not be reached if they were too few.

If this is indeed the case than the error message is not clear.

[srsudar, 2016/09/30 15:07:17]

Good point. I was trying to use this call to ensure that I wouldn't get an index
out of bounds with the array access on the next line, but you're right that this
isn't necessary given the enclosing if/else. Removing.

+        chrome.sockets.udp.close(socketIds[0], function() {
+          chrome.sockets.udp.close(socketIds[1], function() {
+            chrome.test.succeed();

[carlosk, 2016/09/30 02:16:24]

IIUC you created numSocketsExpected to store the amount of times you would like
to reuse the socket in this test. But here it seems you are hard coding that
same information. You should choose either way but not mix both.

[srsudar, 2016/09/30 15:07:17]

Done.

+          });
+        });
+      }
+    }
+
+    chrome.test.assertTrue(createInfo.socketId > 0);
+    socketIds.push(createInfo.socketId);
+
+    chrome.sockets.udp.getInfo(createInfo.socketId, onGetInfoBeforeBind);
+  }
+
+  function createAndBindToSharedAddress() {
+    chrome.sockets.udp.create({ "allowAddressReuse": true }, onCreate);
+  }
+
+  createAndBindToSharedAddress();
+};
+
+
 ///////////////////////////////////////////////////////////////////////////////
 // Test socket send/receive
 //
 
 function waitForBlockingOperation() {
   if (++waitCount < 10) {
     setTimeout(waitForBlockingOperation, 1000);
   } else {
     // We weren't able to succeed in the given time.
     chrome.test.fail("Operations didn't complete after " + waitCount + " " +
@@ skipping 241 matching lines @@
   var test_type = parts[0];
   address = parts[1];
   port = parseInt(parts[2]);
   console.log("Running tests, echo server " +
               address + ":" + port);
   if (test_type == 'multicast') {
     console.log("Running multicast tests");
     chrome.test.runTests([ testMulticast ]);
   } else {
     console.log("Running udp tests");
-    chrome.test.runTests([ testSocketCreation, testSending, testSetPaused,
-                           testBroadcast ]);
+    chrome.test.runTests([ testSocketCreation, testSocketReusable, testSending,
+                           testSetPaused, testBroadcast ]);
   }
 };
 
 // Find out which protocol we're supposed to test, and which echo server we
 // should be using, then kick off the tests.
 chrome.test.sendMessage("info_please", onMessageReply);