Add ability to reuse address in chrome.sockets.udp

extensions/test/data/sockets_udp/api/background.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // net/tools/testserver/testserver.py is picky about the format of what it
 // calls its "echo" messages. One might go so far as to mutter to oneself that
 // it isn't an echo server at all.
 //
 // The response is based on the request but obfuscated using a random key.
 const request = "0100000005320000005hello";
@@ skipping 53 matching lines @@
     chrome.test.assertTrue(createInfo.socketId > 0);
 
     // Obtaining socket information before a connect() call should be safe, but
     // return empty values.
     chrome.sockets.udp.getInfo(createInfo.socketId, onGetInfo);
   }
 
   chrome.sockets.udp.create({}, onCreate);
 };
 
+var testSocketReusable = function() {
+  var address = '224.0.0.251';
+  var port = 5353;
+
+  var numSocketsCreated = 0;
+  var numSocketsExpected = 2;
+
+  var socketIds = [];
+
+  function onCreate(createInfo) {
+    function onBind(result) {
+      chrome.test.assertEq(0, result, 'Bind failed with error: ' + result);
+      chrome.sockets.udp.getInfo(createInfo.socketId, onGetInfoAfterBind);
+    }
+
+    function onGetInfoBeforeBind(info) {
+      if (info.localAddress || info.localPort) {
+        chrome.test.fail('Unconnected socket should not have local binding');
+      }
+
+      chrome.test.assertEq(true, info.addressReusable, 'Should be reusable');
+
+      chrome.sockets.udp.bind(createInfo.socketId, address, port, onBind);
+    }
+
+    function onGetInfoAfterBind(info) {
+      chrome.test.assertEq(address, info.localAddress,
+        'Bound to wrong address');
+      chrome.test.assertEq(port, info.localPort, 'Bound to wrong port');
+      chrome.test.assertEq(true, info.addressReusable, 'Should be reusable');
+
+      if (numSocketsCreated < numSocketsExpected) {
+        // Bind again to ensure the address is reusable.
+        createAndBindToSharedAddress();
+      } else {
+        chrome.test.assertEq(2, numSocketsExpected,
+          'Not all sockets created during test');

[Reilly Grant (use Gerrit), 2016/09/29 06:55:55]

This assert is vacuously true. I assume you meant to test that numSocketsCreated
== numSocketsExpected. numSocketsCreated should probably be incremented in
onGetInfoAfterBind() instead of createAndBindToSharedAddress().

[srsudar, 2016/09/29 19:32:58]

Done.

+        chrome.sockets.udp.close(socketIds[0], function() {
+          chrome.sockets.udp.close(socketIds[1], function() {
+            chrome.test.succeed();
+          });
+        });
+      }
+    }
+
+    chrome.test.assertTrue(createInfo.socketId > 0);
+    socketIds.push(createInfo.socketId);
+
+    chrome.sockets.udp.getInfo(createInfo.socketId, onGetInfoBeforeBind);
+  }
+
+  function createAndBindToSharedAddress() {
+    numSocketsCreated += 1;
+    chrome.sockets.udp.create({ "allowAddressReuse": true }, onCreate);
+  }
+
+  createAndBindToSharedAddress();
+};
+
+
 ///////////////////////////////////////////////////////////////////////////////
 // Test socket send/receive
 //
 
 function waitForBlockingOperation() {
   if (++waitCount < 10) {
     setTimeout(waitForBlockingOperation, 1000);
   } else {
     // We weren't able to succeed in the given time.
     chrome.test.fail("Operations didn't complete after " + waitCount + " " +
@@ skipping 241 matching lines @@
   var test_type = parts[0];
   address = parts[1];
   port = parseInt(parts[2]);
   console.log("Running tests, echo server " +
               address + ":" + port);
   if (test_type == 'multicast') {
     console.log("Running multicast tests");
     chrome.test.runTests([ testMulticast ]);
   } else {
     console.log("Running udp tests");
-    chrome.test.runTests([ testSocketCreation, testSending, testSetPaused,
-                           testBroadcast ]);
+    chrome.test.runTests([ testSocketCreation, testSocketReusable, testSending,
+                           testSetPaused, testBroadcast ]);
   }
 };
 
 // Find out which protocol we're supposed to test, and which echo server we
 // should be using, then kick off the tests.
 chrome.test.sendMessage("info_please", onMessageReply);