Add ability to reuse address in chrome.sockets.udp

extensions/browser/api/socket/udp_socket.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_API_SOCKET_UDP_SOCKET_H_
 #define EXTENSIONS_BROWSER_API_SOCKET_UDP_SOCKET_H_
 
 #include <stdint.h>
 
 #include <string>
@@ skipping 21 matching lines @@
               const CompletionCallback& callback) override;
 
   bool IsConnected() override;
 
   bool GetPeerAddress(net::IPEndPoint* address) override;
   bool GetLocalAddress(net::IPEndPoint* address) override;
   Socket::SocketType GetSocketType() const override;
 
   bool IsBound();
 
+  virtual bool IsReusable();
+
   int JoinGroup(const std::string& address);
   int LeaveGroup(const std::string& address);
 
   int SetMulticastTimeToLive(int ttl);
   int SetMulticastLoopbackMode(bool loopback);
 
   int SetBroadcast(bool enabled);
 
   const std::vector<std::string>& GetJoinedGroups() const;
 
@@ skipping 26 matching lines @@
 // UDP Socket instances from the "sockets.udp" namespace. These are regular
 // socket objects with additional properties related to the behavior defined in
 // the "sockets.udp" namespace.
 class ResumableUDPSocket : public UDPSocket {
  public:
   explicit ResumableUDPSocket(const std::string& owner_extension_id);
 
   // Overriden from ApiResource
   bool IsPersistent() const override;
 
+  bool IsReusable() override;
+
   const std::string& name() const { return name_; }
   void set_name(const std::string& name) { name_ = name; }
 
   bool persistent() const { return persistent_; }
   void set_persistent(bool persistent) { persistent_ = persistent; }
 
   int buffer_size() const { return buffer_size_; }
   void set_buffer_size(int buffer_size) { buffer_size_ = buffer_size; }
 
   bool paused() const { return paused_; }
   void set_paused(bool paused) { paused_ = paused; }
 
+  bool allow_address_reuse() const { return allow_address_reuse_; }
+  void set_allow_address_reuse(bool allow) { allow_address_reuse_ = allow; }
+
  private:
   friend class ApiResourceManager<ResumableUDPSocket>;
   static const char* service_name() { return "ResumableUDPSocketManager"; }
 
   // Application-defined string - see sockets_udp.idl.
   std::string name_;
   // Flag indicating whether the socket is left open when the application is
   // suspended - see sockets_udp.idl.
   bool persistent_;
   // The size of the buffer used to receive data - see sockets_udp.idl.
   int buffer_size_;
   // Flag indicating whether a connected socket blocks its peer from sending
   // more data - see sockets_udp.idl.
   bool paused_;
+  // Flag indicating whether the address can be bound by multiple sockets - see
+  // sockets_udp.idl
+  bool allow_address_reuse_;

[Reilly Grant (use Gerrit), 2016/09/29 06:55:55]

Instead of adding this field to ResumableUDPSocket add it to UDPSocket and then
you don't need an IsReusable() method.

[srsudar, 2016/09/29 19:32:58]

Done.

 };
 
 }  //  namespace extensions
 
 #endif  // EXTENSIONS_BROWSER_API_SOCKET_UDP_SOCKET_H_