Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: src/full-codegen/arm/full-codegen-arm.cc

Issue 2378693002: [intrinsics] Nuke the %_StringCharFromCode intrinsic. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/full-codegen/full-codegen.h" 7 #include "src/full-codegen/full-codegen.h"
8 #include "src/ast/compile-time-value.h" 8 #include "src/ast/compile-time-value.h"
9 #include "src/ast/scopes.h" 9 #include "src/ast/scopes.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 2759 matching lines...) Expand 10 before | Expand all | Expand 10 after
2770 __ bind(&null); 2770 __ bind(&null);
2771 __ LoadRoot(r0, Heap::kNullValueRootIndex); 2771 __ LoadRoot(r0, Heap::kNullValueRootIndex);
2772 2772
2773 // All done. 2773 // All done.
2774 __ bind(&done); 2774 __ bind(&done);
2775 2775
2776 context()->Plug(r0); 2776 context()->Plug(r0);
2777 } 2777 }
2778 2778
2779 2779
2780 void FullCodeGenerator::EmitStringCharFromCode(CallRuntime* expr) {
2781 ZoneList<Expression*>* args = expr->arguments();
2782 DCHECK(args->length() == 1);
2783 VisitForAccumulatorValue(args->at(0));
2784
2785 Label done;
2786 StringCharFromCodeGenerator generator(r0, r1);
2787 generator.GenerateFast(masm_);
2788 __ jmp(&done);
2789
2790 NopRuntimeCallHelper call_helper;
2791 generator.GenerateSlow(masm_, call_helper);
2792
2793 __ bind(&done);
2794 context()->Plug(r1);
2795 }
2796
2797
2798 void FullCodeGenerator::EmitStringCharCodeAt(CallRuntime* expr) { 2780 void FullCodeGenerator::EmitStringCharCodeAt(CallRuntime* expr) {
2799 ZoneList<Expression*>* args = expr->arguments(); 2781 ZoneList<Expression*>* args = expr->arguments();
2800 DCHECK(args->length() == 2); 2782 DCHECK(args->length() == 2);
2801 VisitForStackValue(args->at(0)); 2783 VisitForStackValue(args->at(0));
2802 VisitForAccumulatorValue(args->at(1)); 2784 VisitForAccumulatorValue(args->at(1));
2803 2785
2804 Register object = r1; 2786 Register object = r1;
2805 Register index = r0; 2787 Register index = r0;
2806 Register result = r3; 2788 Register result = r3;
2807 2789
(...skipping 946 matching lines...) Expand 10 before | Expand all | Expand 10 after
3754 DCHECK(interrupt_address == 3736 DCHECK(interrupt_address ==
3755 isolate->builtins()->OnStackReplacement()->entry()); 3737 isolate->builtins()->OnStackReplacement()->entry());
3756 return ON_STACK_REPLACEMENT; 3738 return ON_STACK_REPLACEMENT;
3757 } 3739 }
3758 3740
3759 3741
3760 } // namespace internal 3742 } // namespace internal
3761 } // namespace v8 3743 } // namespace v8
3762 3744
3763 #endif // V8_TARGET_ARCH_ARM 3745 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698