Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 2378643003: Fix initialization in MediaCodecAudioDecoder (Closed)

Created:
4 years, 2 months ago by Tima Vaisburd
Modified:
4 years, 2 months ago
Reviewers:
DaleCurtis, AndyWu
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org, AndyWu
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix initialization in MediaCodecAudioDecoder Move the call to ResetTimestampState() that sets several init parameters before we return from Initialize waiting for the media crypto. Should be part of https://codereview.chromium.org/2376513002/ BUG=650735 Committed: https://crrev.com/ae5d3869802f69c43a1c03790c9292453ea5e9fd Cr-Commit-Position: refs/heads/master@{#421619}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M media/filters/android/media_codec_audio_decoder.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
Tima Vaisburd
PTAL
4 years, 2 months ago (2016-09-28 19:05:07 UTC) #4
DaleCurtis
lgtm
4 years, 2 months ago (2016-09-28 19:21:10 UTC) #5
DaleCurtis
Thanks for the fix!
4 years, 2 months ago (2016-09-28 19:21:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378643003/1
4 years, 2 months ago (2016-09-28 19:53:46 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 20:03:52 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 20:07:16 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ae5d3869802f69c43a1c03790c9292453ea5e9fd
Cr-Commit-Position: refs/heads/master@{#421619}

Powered by Google App Engine
This is Rietveld 408576698