content/common/frame_owner_properties.h - Issue 2378643002: Propagating csp attribute changes on frameOwnerPropertiesChanged()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/common/frame_owner_properties.h

Issue 2378643002: Propagating csp attribute changes on frameOwnerPropertiesChanged() (Closed)

Patch Set: Changing the test class to move the switch Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CONTENT_COMMON_FRAME_OWNER_PROPERTIES_H_	5 #ifndef CONTENT_COMMON_FRAME_OWNER_PROPERTIES_H_

6 #define CONTENT_COMMON_FRAME_OWNER_PROPERTIES_H_	6 #define CONTENT_COMMON_FRAME_OWNER_PROPERTIES_H_

7	7

8 #include <vector>	8 #include <vector>

9	9

10 #include "content/common/content_export.h"	10 #include "content/common/content_export.h"

(...skipping 16 matching lines...) Expand all Loading...
27	27

28 bool operator==(const FrameOwnerProperties& other) const;	28 bool operator==(const FrameOwnerProperties& other) const;

29 bool operator!=(const FrameOwnerProperties& other) const {	29 bool operator!=(const FrameOwnerProperties& other) const {

30 return !(*this == other);	30 return !(*this == other);

31 }	31 }

32	32

33 blink::WebFrameOwnerProperties::ScrollingMode scrolling_mode;	33 blink::WebFrameOwnerProperties::ScrollingMode scrolling_mode;

34 int margin_width;	34 int margin_width;

35 int margin_height;	35 int margin_height;

36 bool allow_fullscreen;	36 bool allow_fullscreen;

	37 base::string16 csp;
	alexmos 2016/09/30 06:20:42 Can this just be a std::string, like other replica Can this just be a std::string, like other replicated properties in FrameReplicationState? alexmos 2016/09/30 06:20:42 Also, how about adding a comment on top of this, j Also, how about adding a comment on top of this, just to explain that this is an experimental attribute, which is different from replicated CSP headers kept in FrameReplicationState. And explain the difference: the former is used by a parent frame to define a CSP for a subframe, whereas the latter tracks the (cumulative) CSP headers currently in effect for a frame. It's probably also usefulещ link to the bug here as well.
37 std::vector<blink::WebPermissionType> delegated_permissions;	38 std::vector<blink::WebPermissionType> delegated_permissions;

38 };	39 };

39	40

40 } // namespace content	41 } // namespace content

41	42

42 #endif // CONTENT_COMMON_FRAME_OWNER_PROPERTIES_H_	43 #endif // CONTENT_COMMON_FRAME_OWNER_PROPERTIES_H_

OLD	NEW