Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2378633002: Add dirty bits on Node indicating need for reattachLayoutTree (Closed)

Created:
4 years, 2 months ago by nainar
Modified:
4 years, 2 months ago
Reviewers:
esprehn, Bugs Nash
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add dirty bits on Node indicating need for reattachLayoutTree Add dirty bits on Node indicating need for: 1. The node itself needs to be reattached (NeedsReattachLayoutTree) 2. One of the node's children needs to be reattached (ChildNeedsReattachLayoutTree) BUG=595137 Committed: https://crrev.com/b56e87fdebf11e10d8a181200b9722b5deb2fcf3 Cr-Commit-Position: refs/heads/master@{#421682}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M third_party/WebKit/Source/core/dom/Node.h View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
nainar
PTAL? Thanks!
4 years, 2 months ago (2016-09-28 08:40:11 UTC) #4
Bugs Nash
lgtm
4 years, 2 months ago (2016-09-28 21:50:07 UTC) #8
esprehn
lgtm
4 years, 2 months ago (2016-09-28 23:26:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378633002/1
4 years, 2 months ago (2016-09-28 23:28:29 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 23:36:36 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 23:46:55 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b56e87fdebf11e10d8a181200b9722b5deb2fcf3
Cr-Commit-Position: refs/heads/master@{#421682}

Powered by Google App Engine
This is Rietveld 408576698