Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: chrome/browser/about_flags.cc

Issue 2378623007: [Material] Update Material Security Verbose Decoration Flag (Closed)
Patch Set: Comment nit Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 5416f60827fa77793f05e807d626d045841e9f84..b9b43f8425822b39717567b4d9bf41d6105795d3 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -644,20 +644,23 @@ const FeatureEntry::Choice kSSLVersionMaxChoices[] = {
{IDS_FLAGS_SSL_VERSION_MAX_TLS13, switches::kSSLVersionMax, "tls1.3"},
};
-const FeatureEntry::Choice kSecurityVerboseChoices[] = {
- {IDS_FLAGS_MATERIAL_SECURITY_VERBOSE_DEFAULT, "", ""},
- {IDS_FLAGS_MATERIAL_SECURITY_VERBOSE_SHOW_ALL_ANIMATED,
- switches::kMaterialSecurityVerbose,
- switches::kMaterialSecurityVerboseShowAllAnimated},
- {IDS_FLAGS_MATERIAL_SECURITY_VERBOSE_SHOW_ALL_NONANIMATED,
- switches::kMaterialSecurityVerbose,
- switches::kMaterialSecurityVerboseShowAllNonAnimated},
- {IDS_FLAGS_MATERIAL_SECURITY_VERBOSE_SHOW_NONSECURE_ANIMATED,
- switches::kMaterialSecurityVerbose,
- switches::kMaterialSecurityVerboseShowNonSecureAnimated},
- {IDS_FLAGS_MATERIAL_SECURITY_VERBOSE_SHOW_NONSECURE_NONANIMATED,
- switches::kMaterialSecurityVerbose,
- switches::kMaterialSecurityVerboseShowNonSecureNonAnimated},
+const FeatureEntry::Choice kSecurityChipChoices[] = {
+ {IDS_FLAGS_SECURITY_CHIP_DEFAULT, "", ""},
+ {IDS_FLAGS_SECURITY_CHIP_SHOW_NONSECURE_ONLY, switches::kSecurityChip,
+ switches::kSecurityChipShowNonSecureOnly},
+ {IDS_FLAGS_SECURITY_CHIP_SHOW_ALL, switches::kSecurityChip,
+ switches::kSecurityChipShowAll},
+};
+
+const FeatureEntry::Choice kSecurityChipAnimationChoices[] = {
+ {IDS_FLAGS_SECURITY_CHIP_ANIMATION_DEFAULT, "", ""},
+ {IDS_FLAGS_SECURITY_CHIP_ANIMATION_NONE, switches::kSecurityChipAnimation,
+ switches::kSecurityChipAnimationNone},
+ {IDS_FLAGS_SECURITY_CHIP_ANIMATION_NONSECURE_ONLY,
+ switches::kSecurityChipAnimation,
+ switches::kSecurityChipAnimationNonSecureOnly},
+ {IDS_FLAGS_SECURITY_CHIP_ANIMATION_ALL, switches::kSecurityChipAnimation,
+ switches::kSecurityChipAnimationAll},
};
// RECORDING USER METRICS FOR FLAGS:
@@ -1562,9 +1565,9 @@ const FeatureEntry kFeatureEntries[] = {
MULTI_VALUE_TYPE(kDataReductionProxyLoFiChoices)},
{"enable-data-reduction-proxy-lite-page",
IDS_FLAGS_ENABLE_DATA_REDUCTION_PROXY_LITE_PAGE_NAME,
- IDS_FLAGS_ENABLE_DATA_REDUCTION_PROXY_LITE_PAGE_DESCRIPTION,
- kOsAll, SINGLE_VALUE_TYPE(data_reduction_proxy::switches::
- kEnableDataReductionProxyLitePage)},
+ IDS_FLAGS_ENABLE_DATA_REDUCTION_PROXY_LITE_PAGE_DESCRIPTION, kOsAll,
+ SINGLE_VALUE_TYPE(
+ data_reduction_proxy::switches::kEnableDataReductionProxyLitePage)},
{"clear-data-reduction-proxy-data-savings",
IDS_FLAGS_DATA_REDUCTION_PROXY_RESET_SAVINGS_NAME,
IDS_FLAGS_DATA_REDUCTION_PROXY_RESET_SAVINGS_DESCRIPTION, kOsAll,
@@ -2103,9 +2106,12 @@ const FeatureEntry kFeatureEntries[] = {
"https://www-googleapis-staging.sandbox.google.com/oauth2/v4/"
"ExchangeToken")},
#endif // OS_CHROMEOS
- {"material-security-verbose", IDS_FLAGS_MATERIAL_SECURITY_VERBOSE_NAME,
- IDS_FLAGS_MATERIAL_SECURITY_VERBOSE_DESCRIPTION, kOsDesktop,
- MULTI_VALUE_TYPE(kSecurityVerboseChoices)},
+ {"security-chip", IDS_FLAGS_SECURITY_CHIP_NAME,
+ IDS_FLAGS_SECURITY_CHIP_DESCRIPTION, kOsDesktop,
+ MULTI_VALUE_TYPE(kSecurityChipChoices)},
+ {"security-chip-animation", IDS_FLAGS_SECURITY_CHIP_ANIMATION_NAME,
+ IDS_FLAGS_SECURITY_CHIP_ANIMATION_DESCRIPTION, kOsDesktop,
+ MULTI_VALUE_TYPE(kSecurityChipAnimationChoices)},
// NOTE: Adding new command-line switches requires adding corresponding
// entries to enum "LoginCustomFlags" in histograms.xml. See note in
// histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.

Powered by Google App Engine
This is Rietveld 408576698