Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2378623003:
Fix FullscreenControllerInteractiveTest.ToggleFullscreenModeForTab (Closed)
|
Created:
4 years, 2 months ago by tapted Modified:
4 years, 2 months ago Reviewers:
Matt Giuca CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix FullscreenControllerInteractiveTest.ToggleFullscreenModeForTab
Test fails with "Check failed: Started(). You must start the server
first." when run with --gtest_also_run_disabled_tests.
Start it.
BUG=651272
Committed: https://crrev.com/6e4dae4ab4eef8252d6dae8262960e1be7936b92
Cr-Commit-Position: refs/heads/master@{#421764}
Patch Set 1 #
Messages
Total messages: 17 (11 generated)
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
Description was changed from ========== Fix test ToggleFullscreenModeForTab Test fails with Check failed: Started(). You must start the server first." when run with --gtest_also_run_disabled_tests. Start it. BUG=651272 ========== to ========== Fix test ToggleFullscreenModeForTab Test fails with Check failed: Started(). You must start the server first." when run with --gtest_also_run_disabled_tests. Start it. BUG=651272 ==========
tapted@chromium.org changed reviewers: + mgiuca@chromium.org
Description was changed from ========== Fix test ToggleFullscreenModeForTab Test fails with Check failed: Started(). You must start the server first." when run with --gtest_also_run_disabled_tests. Start it. BUG=651272 ========== to ========== Fix test ToggleFullscreenModeForTab Test fails with "Check failed: Started(). You must start the server first." when run with --gtest_also_run_disabled_tests. Start it. BUG=651272 ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fix test ToggleFullscreenModeForTab Test fails with "Check failed: Started(). You must start the server first." when run with --gtest_also_run_disabled_tests. Start it. BUG=651272 ========== to ========== Fix FullscreenControllerInteractiveTest.ToggleFullscreenModeForTab Test fails with "Check failed: Started(). You must start the server first." when run with --gtest_also_run_disabled_tests. Start it. BUG=651272 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Can we re-enable the test now?
lgtm We can look at re-enabling later (see https://codereview.chromium.org/2375273003/).
The CQ bit was checked by tapted@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix FullscreenControllerInteractiveTest.ToggleFullscreenModeForTab Test fails with "Check failed: Started(). You must start the server first." when run with --gtest_also_run_disabled_tests. Start it. BUG=651272 ========== to ========== Fix FullscreenControllerInteractiveTest.ToggleFullscreenModeForTab Test fails with "Check failed: Started(). You must start the server first." when run with --gtest_also_run_disabled_tests. Start it. BUG=651272 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix FullscreenControllerInteractiveTest.ToggleFullscreenModeForTab Test fails with "Check failed: Started(). You must start the server first." when run with --gtest_also_run_disabled_tests. Start it. BUG=651272 ========== to ========== Fix FullscreenControllerInteractiveTest.ToggleFullscreenModeForTab Test fails with "Check failed: Started(). You must start the server first." when run with --gtest_also_run_disabled_tests. Start it. BUG=651272 Committed: https://crrev.com/6e4dae4ab4eef8252d6dae8262960e1be7936b92 Cr-Commit-Position: refs/heads/master@{#421764} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/6e4dae4ab4eef8252d6dae8262960e1be7936b92 Cr-Commit-Position: refs/heads/master@{#421764} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
