Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Unified Diff: gpu/command_buffer/service/program_manager.h

Issue 2378583003: Ping watchdog thread during GpuChannel destruction (Closed)
Patch Set: Fix lifetime and use nullptr Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/program_manager.h
diff --git a/gpu/command_buffer/service/program_manager.h b/gpu/command_buffer/service/program_manager.h
index 36bc94e84d1e7f4ce0f7dcd4f9cc6339aeb2471c..e65c65bb6ba50a07f94ae69f515d32c139a9e4ec 100644
--- a/gpu/command_buffer/service/program_manager.h
+++ b/gpu/command_buffer/service/program_manager.h
@@ -31,6 +31,7 @@ namespace gles2 {
class FeatureInfo;
class ProgramCache;
class ProgramManager;
+class ProgressReporter;
class Shader;
class ShaderManager;
@@ -598,7 +599,8 @@ class GPU_EXPORT ProgramManager {
uint32_t max_dual_source_draw_buffers,
uint32_t max_vertex_attribs,
const GpuPreferences& gpu_preferences,
- FeatureInfo* feature_info);
+ FeatureInfo* feature_info,
+ ProgressReporter* progress_reporter);
~ProgramManager();
// Must call before destruction.
@@ -680,6 +682,11 @@ class GPU_EXPORT ProgramManager {
const GpuPreferences& gpu_preferences_;
scoped_refptr<FeatureInfo> feature_info_;
+ // Used to notify the watchdog thread of progress during destruction,
+ // preventing time-outs when destruction takes a long time. May be null when
+ // using in-process command buffer.
+ ProgressReporter* progress_reporter_;
+
DISALLOW_COPY_AND_ASSIGN(ProgramManager);
};

Powered by Google App Engine
This is Rietveld 408576698