gpu/command_buffer/service/in_process_command_buffer.cc - Issue 2378583003: Ping watchdog thread during GpuChannel destruction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/in_process_command_buffer.cc

Issue 2378583003: Ping watchdog thread during GpuChannel destruction (Closed)

Patch Set: Fix lifetime and use nullptr Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/command_buffer/service/in_process_command_buffer.cc

diff --git a/gpu/command_buffer/service/in_process_command_buffer.cc b/gpu/command_buffer/service/in_process_command_buffer.cc

index 53d736483c29e33bb6e62362950d9b7477deb032..3e90f45743be02f79d97006161d402c84dddc54f 100644

--- a/gpu/command_buffer/service/in_process_command_buffer.cc

+++ b/gpu/command_buffer/service/in_process_command_buffer.cc

@@ -330,7 +330,7 @@ bool InProcessCommandBuffer::InitializeOnGpuThread(

service_->gpu_preferences(), service_->mailbox_manager(), NULL,

service_->shader_translator_cache(),

service_->framebuffer_completeness_cache(), feature_info,

- bind_generates_resource, nullptr)));

+ bind_generates_resource, nullptr, nullptr)));

executor_.reset(new CommandExecutor(command_buffer.get(), decoder_.get(),

decoder_.get()));