[HBD] Blanket BLOCK on all non-HTTP(s) and non-FILE URLs for Flash.

chrome/browser/plugins/flash_download_interception_unittest.cc

Index: chrome/browser/plugins/flash_download_interception_unittest.cc
diff --git a/chrome/browser/plugins/flash_download_interception_unittest.cc b/chrome/browser/plugins/flash_download_interception_unittest.cc
index 436eba2e7ca6a3573affaa1952d23d324a0b1d32..3484da0fc9262b3ab62ad823637a27d9a9021613 100644
--- a/chrome/browser/plugins/flash_download_interception_unittest.cc
+++ b/chrome/browser/plugins/flash_download_interception_unittest.cc
@@ -29,7 +29,7 @@ TEST_F(FlashDownloadInterceptionTest, PreferHtmlOverPluginsOff) {
   feature_list.InitAndDisableFeature(features::kPreferHtmlOverPlugins);
 
   EXPECT_FALSE(FlashDownloadInterception::ShouldStopFlashDownloadAction(
-      host_content_settings_map(), GURL(),
+      host_content_settings_map(), GURL("http://source-page.com"),
       GURL("https://get.adobe.com/flashplayer/"), true));
 }
 
@@ -38,20 +38,20 @@ TEST_F(FlashDownloadInterceptionTest, DownloadUrlVariations) {
   feature_list.InitAndEnableFeature(features::kPreferHtmlOverPlugins);
 
   EXPECT_TRUE(FlashDownloadInterception::ShouldStopFlashDownloadAction(
-      host_content_settings_map(), GURL(),
+      host_content_settings_map(), GURL("http://source-page.com"),
       GURL("https://get.adobe.com/flashplayer/"), true));
 
   // HTTP and path variant.
   EXPECT_TRUE(FlashDownloadInterception::ShouldStopFlashDownloadAction(
-      host_content_settings_map(), GURL(), GURL("http://get.adobe.com/flash"),
-      true));
+      host_content_settings_map(), GURL("http://source-page.com"),
+      GURL("http://get.adobe.com/flash"), true));
 
   EXPECT_FALSE(FlashDownloadInterception::ShouldStopFlashDownloadAction(
-      host_content_settings_map(), GURL(), GURL("https://www.example.com"),
-      true));
+      host_content_settings_map(), GURL("http://source-page.com"),
+      GURL("https://www.example.com"), true));
 
   EXPECT_FALSE(FlashDownloadInterception::ShouldStopFlashDownloadAction(
-      host_content_settings_map(), GURL(),
+      host_content_settings_map(), GURL("http://source-page.com"),
       GURL("http://example.com/get.adobe.com/flashplayer"), true));
 }
 
@@ -59,6 +59,9 @@ TEST_F(FlashDownloadInterceptionTest, NavigationThrottleCancelsNavigation) {
   base::test::ScopedFeatureList feature_list;
   feature_list.InitAndEnableFeature(features::kPreferHtmlOverPlugins);
 
+  // Set the source URL to an HTTP source.
+  NavigateAndCommit(GURL("http://example.com"));
+
   std::unique_ptr<NavigationHandle> handle =
       NavigationHandle::CreateNavigationHandleForTesting(
           GURL("https://get.adobe.com/flashplayer"), main_rfh());
@@ -78,7 +81,7 @@ TEST_F(FlashDownloadInterceptionTest, OnlyInterceptOnDetectContentSetting) {
 
   // Default Setting (which is DETECT)
   EXPECT_TRUE(FlashDownloadInterception::ShouldStopFlashDownloadAction(
-      host_content_settings_map(), GURL(),
+      host_content_settings_map(), GURL("http://source-page.com"),
       GURL("https://get.adobe.com/flashplayer/"), true));
 
   // ALLOW and BLOCK Settings
@@ -87,18 +90,18 @@ TEST_F(FlashDownloadInterceptionTest, OnlyInterceptOnDetectContentSetting) {
   map->SetDefaultContentSetting(CONTENT_SETTINGS_TYPE_PLUGINS,
                                 CONTENT_SETTING_ALLOW);
   EXPECT_FALSE(FlashDownloadInterception::ShouldStopFlashDownloadAction(
-      host_content_settings_map(), GURL(),
+      host_content_settings_map(), GURL("http://source-page.com"),
       GURL("https://get.adobe.com/flashplayer/"), true));
   map->SetDefaultContentSetting(CONTENT_SETTINGS_TYPE_PLUGINS,
                                 CONTENT_SETTING_BLOCK);
   EXPECT_FALSE(FlashDownloadInterception::ShouldStopFlashDownloadAction(
-      host_content_settings_map(), GURL(),
+      host_content_settings_map(), GURL("http://source-page.com"),
       GURL("https://get.adobe.com/flashplayer/"), true));
 
   // Explicit DETECT
   map->SetDefaultContentSetting(CONTENT_SETTINGS_TYPE_PLUGINS,
                                 CONTENT_SETTING_DETECT_IMPORTANT_CONTENT);
   EXPECT_TRUE(FlashDownloadInterception::ShouldStopFlashDownloadAction(
-      host_content_settings_map(), GURL(),
+      host_content_settings_map(), GURL("http://source-page.com"),
       GURL("https://get.adobe.com/flashplayer/"), true));
 }