DescriptionRevert of Made ElementRareData store ComputedStyle on LayoutObject if possible. (patchset #5 id:100001 of https://codereview.chromium.org/2293713002/ )
Reason for revert:
Storage of ComputedStyle on LayoutObject causes invalid LayoutObject state. Also no longer required for consistency as Squad project requires redesign and will no longer store ComputedStyle on Node's data union.
Original issue's description:
> Made ElementRareData store ComputedStyle on LayoutObject if possible.
>
> Made ElementRareData store ComputedStyle on LayoutObject of it's base
> class NodeRareDataBase if it has a LayoutObject.
> Otherwise it is stored on the ComputedStyle member of ElementRareData.
>
> The reason for this is to make it consistent with storage of
> ComputedStyle on Node, which stores a union that can be one of:
> 1) a ComputedStyle
> 2) a LayoutObject (ComputedStyle can be stored on this)
> 3) a NodeRareData (LayoutObject can be stored on this which stores
> ComputedStyle or if no LayoutObject ComputedStyle can be stored
> directly on ElementRareData)
>
> This patch encapsulates the logic of where to store the ComputedStyle
> on the ElementRareData so that it doesn't need to be done at the call
> site (e.g. in new method Node::setComputedStyle from
> https://codereview.chromium.org/2001453002)
>
> The clearComputedStyle method is special and only clears the
> ComputedStyle member as its current use is not intended to clear a
> LayoutObject's ComputedStyle.
>
> BUG=595137
>
> Committed: https://crrev.com/c542d3744b905a2a00f5ac2dd2047a6a323ec181
> Cr-Commit-Position: refs/heads/master@{#418453}
TBR=meade@chromium.org,nainar@chromium.org,timloh@chromium.org,esprehn@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=595137
Committed: https://crrev.com/ced6b481f3ebe3886ec5f0dd25e9815a2f8b96c8
Cr-Commit-Position: refs/heads/master@{#421478}
Patch Set 1 #Patch Set 2 : Fixed conflicts (nainar) #
Messages
Total messages: 21 (9 generated)
|