Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2378573002: Revert of Made ElementRareData store ComputedStyle on LayoutObject if possible. (Closed)

Created:
4 years, 2 months ago by Bugs Nash
Modified:
4 years, 2 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Made ElementRareData store ComputedStyle on LayoutObject if possible. (patchset #5 id:100001 of https://codereview.chromium.org/2293713002/ ) Reason for revert: Storage of ComputedStyle on LayoutObject causes invalid LayoutObject state. Also no longer required for consistency as Squad project requires redesign and will no longer store ComputedStyle on Node's data union. Original issue's description: > Made ElementRareData store ComputedStyle on LayoutObject if possible. > > Made ElementRareData store ComputedStyle on LayoutObject of it's base > class NodeRareDataBase if it has a LayoutObject. > Otherwise it is stored on the ComputedStyle member of ElementRareData. > > The reason for this is to make it consistent with storage of > ComputedStyle on Node, which stores a union that can be one of: > 1) a ComputedStyle > 2) a LayoutObject (ComputedStyle can be stored on this) > 3) a NodeRareData (LayoutObject can be stored on this which stores > ComputedStyle or if no LayoutObject ComputedStyle can be stored > directly on ElementRareData) > > This patch encapsulates the logic of where to store the ComputedStyle > on the ElementRareData so that it doesn't need to be done at the call > site (e.g. in new method Node::setComputedStyle from > https://codereview.chromium.org/2001453002) > > The clearComputedStyle method is special and only clears the > ComputedStyle member as its current use is not intended to clear a > LayoutObject's ComputedStyle. > > BUG=595137 > > Committed: https://crrev.com/c542d3744b905a2a00f5ac2dd2047a6a323ec181 > Cr-Commit-Position: refs/heads/master@{#418453} TBR=meade@chromium.org,nainar@chromium.org,timloh@chromium.org,esprehn@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=595137 Committed: https://crrev.com/ced6b481f3ebe3886ec5f0dd25e9815a2f8b96c8 Cr-Commit-Position: refs/heads/master@{#421478}

Patch Set 1 #

Patch Set 2 : Fixed conflicts (nainar) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -55 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ElementRareData.h View 1 1 chunk +3 lines, -19 lines 0 comments Download
D third_party/WebKit/Source/core/dom/ElementRareDataTest.cpp View 1 chunk +0 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/NodeRareData.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (9 generated)
Bugs Nash
Created Revert of Made ElementRareData store ComputedStyle on LayoutObject if possible.
4 years, 2 months ago (2016-09-28 02:15:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378573002/1
4 years, 2 months ago (2016-09-28 02:16:24 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago (2016-09-28 02:16:25 UTC) #5
nainar
lgtm
4 years, 2 months ago (2016-09-28 02:18:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378573002/1
4 years, 2 months ago (2016-09-28 02:18:23 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/76247) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 2 months ago (2016-09-28 02:20:22 UTC) #10
esprehn
lgtm
4 years, 2 months ago (2016-09-28 02:24:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378573002/160001
4 years, 2 months ago (2016-09-28 02:36:09 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/37917)
4 years, 2 months ago (2016-09-28 04:35:01 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378573002/160001
4 years, 2 months ago (2016-09-28 07:21:01 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:160001)
4 years, 2 months ago (2016-09-28 08:18:01 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 08:20:08 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ced6b481f3ebe3886ec5f0dd25e9815a2f8b96c8
Cr-Commit-Position: refs/heads/master@{#421478}

Powered by Google App Engine
This is Rietveld 408576698