Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: third_party/WebKit/Source/core/html/forms/PasswordInputType.h

Issue 2378503002: Observe visibility of password inputs, for HTTP-bad phase 1 (Closed)
Patch Set: fix browser-side binding Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/forms/PasswordInputType.h
diff --git a/third_party/WebKit/Source/core/html/forms/PasswordInputType.h b/third_party/WebKit/Source/core/html/forms/PasswordInputType.h
index cda25e7b0f14b956abe76e3f1d841b84f3c6a436..61648829f1548a412ea8355e947d657c73605047 100644
--- a/third_party/WebKit/Source/core/html/forms/PasswordInputType.h
+++ b/third_party/WebKit/Source/core/html/forms/PasswordInputType.h
@@ -31,6 +31,7 @@
#ifndef PasswordInputType_h
#define PasswordInputType_h
+#include "core/dom/ElementVisibilityObserver.h"
#include "core/html/forms/BaseTextInputType.h"
namespace blink {
@@ -38,9 +39,10 @@ namespace blink {
class PasswordInputType final : public BaseTextInputType {
public:
static InputType* create(HTMLInputElement&);
+ DECLARE_VIRTUAL_TRACE();
private:
- PasswordInputType(HTMLInputElement& element) : BaseTextInputType(element) { }
+ PasswordInputType(HTMLInputElement&);
void countUsage() override;
const AtomicString& formControlType() const override;
bool shouldSaveAndRestoreFormControlState() const override;
@@ -49,6 +51,10 @@ private:
bool shouldRespectListAttribute() override;
void enableSecureTextInput() override;
void disableSecureTextInput() override;
+
+ void onVisibilityChanged(bool isVisible);
+
+ Member<ElementVisibilityObserver> m_visibilityObserver;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698