Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: components/password_manager/content/browser/content_password_manager_driver.cc

Issue 2378503002: Observe visibility of password inputs, for HTTP-bad phase 1 (Closed)
Patch Set: fix browser-side binding Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/content/browser/content_password_manager_driver.cc
diff --git a/components/password_manager/content/browser/content_password_manager_driver.cc b/components/password_manager/content/browser/content_password_manager_driver.cc
index 722416e5ef18a4ce108d6b97ec45a126b8a94a61..d38aadfb2537050f1bb12cb25af02691c351377f 100644
--- a/components/password_manager/content/browser/content_password_manager_driver.cc
+++ b/components/password_manager/content/browser/content_password_manager_driver.cc
@@ -37,6 +37,7 @@ ContentPasswordManagerDriver::ContentPasswordManagerDriver(
password_autofill_manager_(this, autofill_client),
next_free_key_(0),
binding_(this),
+ sensitive_input_visibility_binding_(this),
weak_factory_(this) {}
ContentPasswordManagerDriver::~ContentPasswordManagerDriver() {
@@ -57,6 +58,11 @@ void ContentPasswordManagerDriver::BindRequest(
binding_.Bind(std::move(request));
}
+void ContentPasswordManagerDriver::BindSensitiveInputVisibilityRequest(
+ blink::mojom::SensitiveInputVisibilityServiceRequest request) {
+ sensitive_input_visibility_binding_.Bind(std::move(request));
+}
+
void ContentPasswordManagerDriver::FillPasswordForm(
const autofill::PasswordFormFillData& form_data) {
const int key = next_free_key_++;
@@ -239,6 +245,12 @@ void ContentPasswordManagerDriver::SaveGenerationFieldDetectedByClassifier(
password_form, generation_field);
}
+void ContentPasswordManagerDriver::PasswordFieldVisible() {
+ // TODO(estark): notify the WebContents that a password field was
+ // shown, which will downgrade the security UI
+ // appropriately. https://crbug.com/647560
+}
+
void ContentPasswordManagerDriver::ShowPasswordSuggestions(
int key,
base::i18n::TextDirection text_direction,

Powered by Google App Engine
This is Rietveld 408576698