components/autofill/content/renderer/renderer_save_password_progress_logger_unittest.cc - Issue 2378503002: Observe visibility of password inputs, for HTTP-bad phase 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/renderer_save_password_progress_logger_unittest.cc

Issue 2378503002: Observe visibility of password inputs, for HTTP-bad phase 1 (Closed)

Patch Set: fix components_unittests build failure Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/renderer/password_autofill_agent.cc ('k') | components/password_manager/content/browser/content_password_manager_driver.h » ('j') | third_party/WebKit/Source/core/html/HTMLInputElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/renderer_save_password_progress_logger_unittest.cc

diff --git a/components/autofill/content/renderer/renderer_save_password_progress_logger_unittest.cc b/components/autofill/content/renderer/renderer_save_password_progress_logger_unittest.cc

index 874f534e8ade4c8ebf7fbc7681115aba6a6f0670..9fcc080d20271661919140f4b85efac0b3191dc1 100644

--- a/components/autofill/content/renderer/renderer_save_password_progress_logger_unittest.cc

+++ b/components/autofill/content/renderer/renderer_save_password_progress_logger_unittest.cc

@@ -72,6 +72,8 @@ class FakeContentPasswordManagerDriver : public mojom::PasswordManagerDriver {

const autofill::PasswordForm& password_form,

const base::string16& generation_field) override {}

+ void PasswordFieldVisible() override {}

// Records whether RecordSavePasswordProgress() gets called.

bool called_record_save_;

// Records data received via RecordSavePasswordProgress() call.