components/password_manager/DEPS - Issue 2378503002: Observe visibility of password inputs, for HTTP-bad phase 1

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/password_manager/DEPS

Issue 2378503002: Observe visibility of password inputs, for HTTP-bad phase 1 (Closed)

Patch Set: fix browser-side binding Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | components/password_manager/content/browser/content_password_manager_driver.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+components/autofill/core/common",	2 "+components/autofill/core/common",

3 "+components/os_crypt",	3 "+components/os_crypt",

4 "+components/password_manager/core",	4 "+components/password_manager/core",

5 "+components/prefs",	5 "+components/prefs",

6 "+components/strings/grit",	6 "+components/strings/grit",

7 "+components/sync/api",	7 "+components/sync/api",

8 "+components/sync/protocol",	8 "+components/sync/protocol",

9 "+net/base",	9 "+net/base",

10 "+net/http/http_status_code.h",	10 "+net/http/http_status_code.h",

11 "+net/url_request",	11 "+net/url_request",

12 "+sql",	12 "+sql",

13 "+third_party/re2",	13 "+third_party/re2",

14 "+third_party/sqlite/sqlite3.h",	14 "+third_party/sqlite/sqlite3.h",

	15 "+third_party/WebKit/public/platform/modules/sensitive_input_visibility/sensit ive_input_visibility_service.mojom.h",
	vabr (Chromium) 2016/09/28 08:49:47 This dependency cannot be added here, because comp This dependency cannot be added here, because components/password_manager is used also on iOS, where WebKit is not used. Instead you probably want to add it in components/password_manager/content. estark 2016/10/06 02:49:38 Done. I also ended up splitting this out into a s Show quoted text On 2016/09/28 08:49:47, vabr (Chromium) wrote: > This dependency cannot be added here, because components/password_manager is > used also on iOS, where WebKit is not used. Instead you probably want to add it > in components/password_manager/content. Done. I also ended up splitting this out into a separate PasswordVisibilityService, because it looks to me (?) like the same implementation isn't meant to be used for multiple Mojo interfaces.
15 "+ui",	16 "+ui",

16 # PasswordManager is a layered component; subdirectories must explicitly	17 # PasswordManager is a layered component; subdirectories must explicitly

17 # introduce the ability to use non-core layers as appropriate.	18 # introduce the ability to use non-core layers as appropriate.

18 "-components/password_manager/content",	19 "-components/password_manager/content",

19 "-components/password_manager/sync",	20 "-components/password_manager/sync",

20 ]	21 ]

OLD	NEW