Observe visibility of password inputs, for HTTP-bad phase 1

third_party/WebKit/Source/web/ChromeClientImpl.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 1052 matching lines @@
         webframe->autofillClient()->dataListOptionsChanged(WebInputElement(&input));
 }
 
 void ChromeClientImpl::ajaxSucceeded(LocalFrame* frame)
 {
     WebLocalFrameImpl* webframe = WebLocalFrameImpl::fromFrame(frame);
     if (webframe->autofillClient())
         webframe->autofillClient()->ajaxSucceeded();
 }
 
+void ChromeClientImpl::passwordFieldBecameVisible(HTMLInputElement& input)
+{
+    WebLocalFrameImpl* webframe = WebLocalFrameImpl::fromFrame(input.document().frame());
+    if (webframe->autofillClient())
+        webframe->autofillClient()->passwordFieldBecameVisible();

[esprehn, 2016/09/27 23:30:19]

Please use mojo directly instead, I don't want to plumb out more callbacks.

[estark, 2016/09/27 23:35:42]

Can you point to an example of what you mean by "use mojo directly"? I'm a mojo
noob and am not sure what that means.

[estark, 2016/09/27 23:39:42]

Oh, actually, I just found and am reading
https://dev.chromium.org/developers/design-documents/mojo/calling-mojo-from-b...
and have a feeling that will answer my question. :)

+}
+
 void ChromeClientImpl::registerViewportLayers() const
 {
     if (m_webView->rootGraphicsLayer() && m_webView->layerTreeView())
         m_webView->registerViewportLayersWithCompositor();
 }
 
 void ChromeClientImpl::didUpdateTopControls() const
 {
     m_webView->didUpdateTopControls();
 }
@@ skipping 68 matching lines @@
     ScreenOrientationController::provideTo(frame, client ? client->webScreenOrientationClient() : nullptr);
     if (RuntimeEnabledFeatures::presentationEnabled())
         PresentationController::provideTo(frame, client ? client->presentationClient() : nullptr);
     if (RuntimeEnabledFeatures::audioOutputDevicesEnabled())
         provideAudioOutputDeviceClientTo(frame, AudioOutputDeviceClientImpl::create());
     if (RuntimeEnabledFeatures::installedAppEnabled())
         InstalledAppController::provideTo(frame, client ? client->installedAppClient() : nullptr);
 }
 
 } // namespace blink