Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Side by Side Diff: components/password_manager/content/browser/content_password_manager_driver.cc

Issue 2378503002: Observe visibility of password inputs, for HTTP-bad phase 1 (Closed)
Patch Set: fix components_unittests build failure Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/password_manager/content/browser/content_password_manager_d river.h" 5 #include "components/password_manager/content/browser/content_password_manager_d river.h"
6 6
7 #include "components/autofill/content/browser/content_autofill_driver.h" 7 #include "components/autofill/content/browser/content_autofill_driver.h"
8 #include "components/autofill/core/common/form_data.h" 8 #include "components/autofill/core/common/form_data.h"
9 #include "components/autofill/core/common/password_form.h" 9 #include "components/autofill/core/common/password_form.h"
10 #include "components/password_manager/content/browser/bad_message.h" 10 #include "components/password_manager/content/browser/bad_message.h"
(...skipping 221 matching lines...) Expand 10 before | Expand all | Expand 10 after
232 const base::string16& generation_field) { 232 const base::string16& generation_field) {
233 if (!CheckChildProcessSecurityPolicy( 233 if (!CheckChildProcessSecurityPolicy(
234 password_form.origin, 234 password_form.origin,
235 BadMessageReason:: 235 BadMessageReason::
236 CPMD_BAD_ORIGIN_SAVE_GENERATION_FIELD_DETECTED_BY_CLASSIFIER)) 236 CPMD_BAD_ORIGIN_SAVE_GENERATION_FIELD_DETECTED_BY_CLASSIFIER))
237 return; 237 return;
238 GetPasswordManager()->SaveGenerationFieldDetectedByClassifier( 238 GetPasswordManager()->SaveGenerationFieldDetectedByClassifier(
239 password_form, generation_field); 239 password_form, generation_field);
240 } 240 }
241 241
242 void ContentPasswordManagerDriver::PasswordFieldVisible() {
243 // TODO(estark): notify the WebContents that a password field was
244 // shown, which will downgrade the security UI
245 // appropriately. https://crbug.com/647560
246 }
247
242 void ContentPasswordManagerDriver::ShowPasswordSuggestions( 248 void ContentPasswordManagerDriver::ShowPasswordSuggestions(
243 int key, 249 int key,
244 base::i18n::TextDirection text_direction, 250 base::i18n::TextDirection text_direction,
245 const base::string16& typed_username, 251 const base::string16& typed_username,
246 int options, 252 int options,
247 const gfx::RectF& bounds) { 253 const gfx::RectF& bounds) {
248 password_autofill_manager_.OnShowPasswordSuggestions( 254 password_autofill_manager_.OnShowPasswordSuggestions(
249 key, text_direction, typed_username, options, bounds); 255 key, text_direction, typed_username, options, bounds);
250 } 256 }
251 257
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
300 ContentPasswordManagerDriver::GetPasswordGenerationAgent() { 306 ContentPasswordManagerDriver::GetPasswordGenerationAgent() {
301 if (!password_gen_agent_) { 307 if (!password_gen_agent_) {
302 render_frame_host_->GetRemoteInterfaces()->GetInterface( 308 render_frame_host_->GetRemoteInterfaces()->GetInterface(
303 mojo::GetProxy(&password_gen_agent_)); 309 mojo::GetProxy(&password_gen_agent_));
304 } 310 }
305 311
306 return password_gen_agent_; 312 return password_gen_agent_;
307 } 313 }
308 314
309 } // namespace password_manager 315 } // namespace password_manager
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698