Disable "Pair" button when selected item is disabled/removed for chooser on Android

Disable "Pair" button when selected item is disabled/removed for chooser on Android

For chooser on Android, when user selects an item and then the item is
disabled or removed, the "Pair" button should be disabled. This CL added
code to fix it.

BUG=639057
Committed: https://crrev.com/976473cc485cc3694eec6f3518d8dbd55513f10b
Cr-Commit-Position: refs/heads/master@{#421564}

[juncai, 2016-09-27 19:05:26]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 19:06:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2016-09-27 19:07:01]

juncai@chromium.org changed reviewers:
+ tedchoc@chromium.org

[juncai, 2016-09-27 19:07:02]

Please take a look.

[commit-bot: I haz the power, 2016-09-27 19:39:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 19:39:39]

Dry run: This issue passed the CQ dry run.

[Ted C, 2016-09-27 23:14:52]

https://codereview.chromium.org/2378433002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java
(right):

https://codereview.chromium.org/2378433002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java:206:
ItemChooserRow selectedRow = getItem(mSelectedItem);
when you remove an item, the selection doesn't move up a row by default?

I do wonder if it is different if you had a hardware keyboard attached, but that
is certainly an edge case.

https://codereview.chromium.org/2378433002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java:250:
* Sets whether the itam is enabled. Disabled items are grayed out.
since you're here, can you can itam to item

https://codereview.chromium.org/2378433002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java:259:
if (mSelectedItem != ListView.INVALID_POSITION) {
I'm wondering if this block should be moved out of this if/else and whether you
should pass enabled instead of false into setEnabled (my thinking is what
happens if you disable and item and then re-enable it?, the button wouldn't get
enabled).

[juncai, 2016-09-28 17:17:55]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 17:18:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2016-09-28 17:19:34]

https://codereview.chromium.org/2378433002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java
(right):

https://codereview.chromium.org/2378433002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java:206:
ItemChooserRow selectedRow = getItem(mSelectedItem);
On 2016/09/27 23:14:52, Ted C wrote:
> when you remove an item, the selection doesn't move up a row by default?
> 
> I do wonder if it is different if you had a hardware keyboard attached, but
that
> is certainly an edge case.

I changed the code to handle this case:
1. If the removed item is the currently selected item, then the chooser will not
have any selected item.
2. If the removed item is before the currently selected item, then the index of
the selected item needs to be adjusted by one.

I also added code to test it.

Done.

https://codereview.chromium.org/2378433002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java:250:
* Sets whether the itam is enabled. Disabled items are grayed out.
On 2016/09/27 23:14:52, Ted C wrote:
> since you're here, can you can itam to item

Done.

https://codereview.chromium.org/2378433002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java:259:
if (mSelectedItem != ListView.INVALID_POSITION) {
On 2016/09/27 23:14:52, Ted C wrote:
> I'm wondering if this block should be moved out of this if/else and whether
you
> should pass enabled instead of false into setEnabled (my thinking is what
> happens if you disable and item and then re-enable it?, the button wouldn't
get
> enabled).

Done.

[Ted C, 2016-09-28 17:30:57]

lgtm

[commit-bot: I haz the power, 2016-09-28 17:48:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 17:48:20]

Dry run: This issue passed the CQ dry run.

[juncai, 2016-09-28 17:49:16]

The CQ bit was checked by juncai@chromium.org

[commit-bot: I haz the power, 2016-09-28 17:49:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 17:58:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-28 18:01:57]

Description was changed from

==========
Disable "Pair" button when selected item is disabled/removed for chooser on
Android

For chooser on Android, when user selects an item and then the item is
disabled or removed, the "Pair" button should be disabled. This CL added
code to fix it.

BUG=639057
==========

to

==========
Disable "Pair" button when selected item is disabled/removed for chooser on
Android

For chooser on Android, when user selects an item and then the item is
disabled or removed, the "Pair" button should be disabled. This CL added
code to fix it.

BUG=639057

Committed: https://crrev.com/976473cc485cc3694eec6f3518d8dbd55513f10b
Cr-Commit-Position: refs/heads/master@{#421564}
==========

[commit-bot: I haz the power, 2016-09-28 18:01:58]

Patchset 2 (id:??) landed as
https://crrev.com/976473cc485cc3694eec6f3518d8dbd55513f10b
Cr-Commit-Position: refs/heads/master@{#421564}