[Android] Add --no-timeout to perf sharder.

build/android/test_runner.py

Index: build/android/test_runner.py
diff --git a/build/android/test_runner.py b/build/android/test_runner.py
index 2c87df901f8499afdecc314bf046a87cd563ba32..032935d86600b3b72429aa889437e9cb7ec9a251 100755
--- a/build/android/test_runner.py
+++ b/build/android/test_runner.py
@@ -4,11 +4,7 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-"""Runs all types of tests from one unified interface.
-
-TODO(gkanwar):
-* Add options to run Monkey tests.
-"""
+"""Runs all types of tests from one unified interface."""
 
 import collections
 import logging
@@ -433,14 +429,20 @@ def AddPerfTestOptions(option_parser):
   option_parser.command_list = []
   option_parser.example = ('%prog perf --steps perf_steps.json')
 
-  option_parser.add_option('--steps', help='JSON file containing the list '
-      'of perf steps to run.')
-  option_parser.add_option('--flaky-steps',
-                           help='A JSON file containing steps that are flaky '
-                                'and will have its exit code ignored.')
-  option_parser.add_option('--print-step', help='The name of a previously '
-      'executed perf step to print.')
-
+  option_parser.add_option(
+      '--steps',
+      help='JSON file containing the list of perf steps to run.')
+  option_parser.add_option(
+      '--flaky-steps',
+      help=('A JSON file containing steps that are flaky '
+            'and will have its exit code ignored.'))
+  option_parser.add_option(
+      '--print-step',
+      help='The name of a previously executed perf step to print.')
+  option_parser.add_option(
+      '--no-timeout', action='store_true',
+      help=('Do not impose a timeout. Each step is responsible for settting '

[craigdh, 2013/09/05 22:25:56]

The word "setting" is unclear. Is each step responsible for implementing its own
timeout mechanism?

[frankf, 2013/09/05 22:36:07]

Rephrased.

On 2013/09/05 22:25:56, craigdh wrote:

+            'a reasonable timeout.'))
   AddCommonOptions(option_parser)
 
 
@@ -458,7 +460,8 @@ def ProcessPerfTestOptions(options, error_func):
   if not options.steps and not options.print_step:
     error_func('Please specify --steps or --print-step')
   return perf_test_options.PerfOptions(
-      options.steps, options.flaky_steps, options.print_step)
+      options.steps, options.flaky_steps, options.print_step,
+      options.no_timeout)
 
 
 def _RunGTests(options, error_func, devices):