Issue 23784006: [Android] Add --no-timeout to perf sharder.

Issue 23784006: [Android] Add --no-timeout to perf sharder. (Closed)

Created:
7 years, 3 months ago by frankf

Modified:
7 years, 3 months ago

Reviewers:
craigdh, bulach

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android] Add --no-timeout to perf sharder. This delegates timeout logic to the step command. BUG= R=bulach@chromium.org, craigdh@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221721

Patch Set 3 : Pass retries through #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -17 lines)			Patch
M	build/android/pylib/perf/test_options.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	build/android/pylib/perf/test_runner.py	View		1 chunk	+6 lines, -1 line	0 comments	Download
M	build/android/test_runner.py	View	1 2	5 chunks	+21 lines, -16 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

craigdh

lgtm w/ nit https://codereview.chromium.org/23784006/diff/1/build/android/test_runner.py File build/android/test_runner.py (right): https://codereview.chromium.org/23784006/diff/1/build/android/test_runner.py#newcode444 build/android/test_runner.py:444: help=('Do not impose a timeout. Each ...

7 years, 3 months ago (2013-09-05 22:25:56 UTC) #2

frankf

https://codereview.chromium.org/23784006/diff/1/build/android/test_runner.py File build/android/test_runner.py (right): https://codereview.chromium.org/23784006/diff/1/build/android/test_runner.py#newcode444 build/android/test_runner.py:444: help=('Do not impose a timeout. Each step is responsible ...

7 years, 3 months ago (2013-09-05 22:36:07 UTC) #3

frankf

7 years, 3 months ago (2013-09-06 17:13:50 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 manually as r221721 (presubmit successful).

Expand Messages | Collapse Messages