content/browser/frame_host/navigation_entry_impl.cc - Issue 2378393002: Pass the user_gesture context in the IPC message FrameMsg_CommitNavigation to the renderer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_entry_impl.cc

Issue 2378393002: Pass the user_gesture context in the IPC message FrameMsg_CommitNavigation to the renderer. (Closed)

Patch Set: Address review comments. Define the has_user_gesture flag in the RequestNavigationParams structure. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/navigation_entry_impl.cc

diff --git a/content/browser/frame_host/navigation_entry_impl.cc b/content/browser/frame_host/navigation_entry_impl.cc

index fbf56542c1609eae1051a8926899c51de2ef4d93..a44e9548b135c86285b1d8a9219fb85f954d2a6b 100644

--- a/content/browser/frame_host/navigation_entry_impl.cc

+++ b/content/browser/frame_host/navigation_entry_impl.cc

@@ -722,7 +722,7 @@ RequestNavigationParams NavigationEntryImpl::ConstructRequestNavigationParams(

is_same_document_history_load, is_history_navigation_in_new_child,

has_subtree_history_items, has_committed_real_load, intended_as_new_entry,

pending_offset_to_send, current_offset_to_send, current_length_to_send,

- IsViewSourceMode(), should_clear_history_list());

+ IsViewSourceMode(), should_clear_history_list(), false);

#if defined(OS_ANDROID)

if (GetDataURLAsString() &&

GetDataURLAsString()->size() <= kMaxLengthOfDataURLString) {