Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: content/common/navigation_params.h

Issue 2378393002: Pass the user_gesture context in the IPC message FrameMsg_CommitNavigation to the renderer. (Closed)
Patch Set: Address review comments. Define the has_user_gesture flag in the RequestNavigationParams structure. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/common/frame_messages.h ('k') | content/common/navigation_params.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_COMMON_NAVIGATION_PARAMS_H_ 5 #ifndef CONTENT_COMMON_NAVIGATION_PARAMS_H_
6 #define CONTENT_COMMON_NAVIGATION_PARAMS_H_ 6 #define CONTENT_COMMON_NAVIGATION_PARAMS_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <string> 10 #include <string>
(...skipping 217 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 int nav_entry_id, 228 int nav_entry_id,
229 bool is_same_document_history_load, 229 bool is_same_document_history_load,
230 bool is_history_navigation_in_new_child, 230 bool is_history_navigation_in_new_child,
231 bool has_subtree_history_items, 231 bool has_subtree_history_items,
232 bool has_committed_real_load, 232 bool has_committed_real_load,
233 bool intended_as_new_entry, 233 bool intended_as_new_entry,
234 int pending_history_list_offset, 234 int pending_history_list_offset,
235 int current_history_list_offset, 235 int current_history_list_offset,
236 int current_history_list_length, 236 int current_history_list_length,
237 bool is_view_source, 237 bool is_view_source,
238 bool should_clear_history_list); 238 bool should_clear_history_list,
239 bool has_user_gesture);
239 RequestNavigationParams(const RequestNavigationParams& other); 240 RequestNavigationParams(const RequestNavigationParams& other);
240 ~RequestNavigationParams(); 241 ~RequestNavigationParams();
241 242
242 // Whether or not the user agent override string should be used. 243 // Whether or not the user agent override string should be used.
243 bool is_overriding_user_agent; 244 bool is_overriding_user_agent;
244 245
245 // Any redirect URLs that occurred before |url|. Useful for cross-process 246 // Any redirect URLs that occurred before |url|. Useful for cross-process
246 // navigations; defaults to empty. 247 // navigations; defaults to empty.
247 std::vector<GURL> redirects; 248 std::vector<GURL> redirects;
248 249
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
327 // Timing of navigation events. 328 // Timing of navigation events.
328 NavigationTiming navigation_timing; 329 NavigationTiming navigation_timing;
329 330
330 // PlzNavigate 331 // PlzNavigate
331 // The ServiceWorkerProviderHost ID used for navigations, if it was already 332 // The ServiceWorkerProviderHost ID used for navigations, if it was already
332 // created by the browser. Set to kInvalidServiceWorkerProviderId otherwise. 333 // created by the browser. Set to kInvalidServiceWorkerProviderId otherwise.
333 // This parameter is not used in the current navigation architecture, where 334 // This parameter is not used in the current navigation architecture, where
334 // it will always be equal to kInvalidServiceWorkerProviderId. 335 // it will always be equal to kInvalidServiceWorkerProviderId.
335 int service_worker_provider_id; 336 int service_worker_provider_id;
336 337
338 // True if the navigation originated due to a user gesture.
339 bool has_user_gesture;
jam 2016/09/29 21:40:43 now this can be removed from StartNavigationParams
ananta 2016/09/29 22:07:37 Done.
340
337 #if defined(OS_ANDROID) 341 #if defined(OS_ANDROID)
338 // The real content of the data: URL. Only used in Android WebView for 342 // The real content of the data: URL. Only used in Android WebView for
339 // implementing LoadDataWithBaseUrl API method to circumvent the restriction 343 // implementing LoadDataWithBaseUrl API method to circumvent the restriction
340 // on the GURL max length in the IPC layer. Short data: URLs can still be 344 // on the GURL max length in the IPC layer. Short data: URLs can still be
341 // passed in the |CommonNavigationParams::url| field. 345 // passed in the |CommonNavigationParams::url| field.
342 std::string data_url_as_string; 346 std::string data_url_as_string;
343 #endif 347 #endif
344 }; 348 };
345 349
346 // Helper struct keeping track in one place of all the parameters the browser 350 // Helper struct keeping track in one place of all the parameters the browser
347 // needs to provide to the renderer. 351 // needs to provide to the renderer.
348 struct NavigationParams { 352 struct NavigationParams {
349 NavigationParams(const CommonNavigationParams& common_params, 353 NavigationParams(const CommonNavigationParams& common_params,
350 const StartNavigationParams& start_params, 354 const StartNavigationParams& start_params,
351 const RequestNavigationParams& request_params); 355 const RequestNavigationParams& request_params);
352 ~NavigationParams(); 356 ~NavigationParams();
353 357
354 CommonNavigationParams common_params; 358 CommonNavigationParams common_params;
355 StartNavigationParams start_params; 359 StartNavigationParams start_params;
356 RequestNavigationParams request_params; 360 RequestNavigationParams request_params;
357 }; 361 };
358 362
359 } // namespace content 363 } // namespace content
360 364
361 #endif // CONTENT_COMMON_NAVIGATION_PARAMS_H_ 365 #endif // CONTENT_COMMON_NAVIGATION_PARAMS_H_
OLDNEW
« no previous file with comments | « content/common/frame_messages.h ('k') | content/common/navigation_params.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698