Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: content/common/frame_messages.h

Issue 2378393002: Pass the user_gesture context in the IPC message FrameMsg_CommitNavigation to the renderer. (Closed)
Patch Set: Address review comments. Define the has_user_gesture flag in the RequestNavigationParams structure. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // IPC messages for interacting with frames. 5 // IPC messages for interacting with frames.
6 // Multiply-included message file, hence no include guard. 6 // Multiply-included message file, hence no include guard.
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 373 matching lines...) Expand 10 before | Expand all | Expand 10 after
384 IPC_STRUCT_TRAITS_MEMBER(has_committed_real_load) 384 IPC_STRUCT_TRAITS_MEMBER(has_committed_real_load)
385 IPC_STRUCT_TRAITS_MEMBER(intended_as_new_entry) 385 IPC_STRUCT_TRAITS_MEMBER(intended_as_new_entry)
386 IPC_STRUCT_TRAITS_MEMBER(pending_history_list_offset) 386 IPC_STRUCT_TRAITS_MEMBER(pending_history_list_offset)
387 IPC_STRUCT_TRAITS_MEMBER(current_history_list_offset) 387 IPC_STRUCT_TRAITS_MEMBER(current_history_list_offset)
388 IPC_STRUCT_TRAITS_MEMBER(current_history_list_length) 388 IPC_STRUCT_TRAITS_MEMBER(current_history_list_length)
389 IPC_STRUCT_TRAITS_MEMBER(is_view_source) 389 IPC_STRUCT_TRAITS_MEMBER(is_view_source)
390 IPC_STRUCT_TRAITS_MEMBER(should_clear_history_list) 390 IPC_STRUCT_TRAITS_MEMBER(should_clear_history_list)
391 IPC_STRUCT_TRAITS_MEMBER(should_create_service_worker) 391 IPC_STRUCT_TRAITS_MEMBER(should_create_service_worker)
392 IPC_STRUCT_TRAITS_MEMBER(navigation_timing) 392 IPC_STRUCT_TRAITS_MEMBER(navigation_timing)
393 IPC_STRUCT_TRAITS_MEMBER(service_worker_provider_id) 393 IPC_STRUCT_TRAITS_MEMBER(service_worker_provider_id)
394 IPC_STRUCT_TRAITS_MEMBER(has_user_gesture)
394 #if defined(OS_ANDROID) 395 #if defined(OS_ANDROID)
395 IPC_STRUCT_TRAITS_MEMBER(data_url_as_string) 396 IPC_STRUCT_TRAITS_MEMBER(data_url_as_string)
396 #endif 397 #endif
397 IPC_STRUCT_TRAITS_END() 398 IPC_STRUCT_TRAITS_END()
398 399
399 IPC_STRUCT_TRAITS_BEGIN(content::FrameReplicationState) 400 IPC_STRUCT_TRAITS_BEGIN(content::FrameReplicationState)
400 IPC_STRUCT_TRAITS_MEMBER(origin) 401 IPC_STRUCT_TRAITS_MEMBER(origin)
401 IPC_STRUCT_TRAITS_MEMBER(sandbox_flags) 402 IPC_STRUCT_TRAITS_MEMBER(sandbox_flags)
402 IPC_STRUCT_TRAITS_MEMBER(name) 403 IPC_STRUCT_TRAITS_MEMBER(name)
403 IPC_STRUCT_TRAITS_MEMBER(unique_name) 404 IPC_STRUCT_TRAITS_MEMBER(unique_name)
(...skipping 489 matching lines...) Expand 10 before | Expand all | Expand 10 after
893 #endif 894 #endif
894 895
895 // PlzNavigate 896 // PlzNavigate
896 // Tells the renderer that a navigation is ready to commit. The renderer should 897 // Tells the renderer that a navigation is ready to commit. The renderer should
897 // request |stream_url| to get access to the stream containing the body of the 898 // request |stream_url| to get access to the stream containing the body of the
898 // response. 899 // response.
899 IPC_MESSAGE_ROUTED4(FrameMsg_CommitNavigation, 900 IPC_MESSAGE_ROUTED4(FrameMsg_CommitNavigation,
900 content::ResourceResponseHead, /* response */ 901 content::ResourceResponseHead, /* response */
901 GURL, /* stream_url */ 902 GURL, /* stream_url */
902 content::CommonNavigationParams, /* common_params */ 903 content::CommonNavigationParams, /* common_params */
903 content::RequestNavigationParams) /* request_params */ 904 content::RequestNavigationParams /* request_params */)
904 905
905 // PlzNavigate 906 // PlzNavigate
906 // Tells the renderer that a navigation failed with the error code |error_code| 907 // Tells the renderer that a navigation failed with the error code |error_code|
907 // and that the renderer should display an appropriate error page. 908 // and that the renderer should display an appropriate error page.
908 IPC_MESSAGE_ROUTED4(FrameMsg_FailedNavigation, 909 IPC_MESSAGE_ROUTED4(FrameMsg_FailedNavigation,
909 content::CommonNavigationParams, /* common_params */ 910 content::CommonNavigationParams, /* common_params */
910 content::RequestNavigationParams, /* request_params */ 911 content::RequestNavigationParams, /* request_params */
911 bool, /* stale_copy_in_cache */ 912 bool, /* stale_copy_in_cache */
912 int /* error_code */) 913 int /* error_code */)
913 914
(...skipping 656 matching lines...) Expand 10 before | Expand all | Expand 10 after
1570 // nearest find result in the sending frame. 1571 // nearest find result in the sending frame.
1571 IPC_MESSAGE_ROUTED2(FrameHostMsg_GetNearestFindResult_Reply, 1572 IPC_MESSAGE_ROUTED2(FrameHostMsg_GetNearestFindResult_Reply,
1572 int /* nfr_request_id */, 1573 int /* nfr_request_id */,
1573 float /* distance */) 1574 float /* distance */)
1574 #endif 1575 #endif
1575 1576
1576 // Adding a new message? Stick to the sort order above: first platform 1577 // Adding a new message? Stick to the sort order above: first platform
1577 // independent FrameMsg, then ifdefs for platform specific FrameMsg, then 1578 // independent FrameMsg, then ifdefs for platform specific FrameMsg, then
1578 // platform independent FrameHostMsg, then ifdefs for platform specific 1579 // platform independent FrameHostMsg, then ifdefs for platform specific
1579 // FrameHostMsg. 1580 // FrameHostMsg.
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698