Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2378383002: skpbench: use accumulative result as the default (Closed)

Created:
4 years, 2 months ago by csmartdalton
Modified:
4 years, 2 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

skpbench: use accumulative result as the default Uses accum instead of median for the first column in skpbench.cpp, and the default result for parseskpbench.py. The accum is empirically proving to be more repeatable than the median. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2378383002 Committed: https://skia.googlesource.com/skia/+/6904b19f18006a4130f8a3a19169b2a5e01fe208

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -17 lines) Patch
M tools/skpbench/_benchresult.py View 3 chunks +9 lines, -9 lines 0 comments Download
M tools/skpbench/parseskpbench.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/skpbench/skpbench.cpp View 3 chunks +5 lines, -6 lines 0 comments Download
M tools/skpbench/skpbench.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
csmartdalton
4 years, 2 months ago (2016-09-29 04:49:39 UTC) #4
bsalomon
lgtm
4 years, 2 months ago (2016-09-29 12:53:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378383002/1
4 years, 2 months ago (2016-09-29 12:55:27 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 13:23:27 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6904b19f18006a4130f8a3a19169b2a5e01fe208

Powered by Google App Engine
This is Rietveld 408576698