Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2378373004: Update comment in build/toolchain/goma.gni (Closed)

Created:
4 years, 2 months ago by tikuta
Modified:
4 years, 2 months ago
Reviewers:
Dirk Pranke, ukai
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update comment in build/toolchain/goma.gni BUG=651288 Committed: https://crrev.com/d2fb90f92170db21dabbbdb7ec38fd5252ef88a0 Cr-Commit-Position: refs/heads/master@{#422036}

Patch Set 1 #

Total comments: 2

Patch Set 2 : add binary #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/toolchain/goma.gni View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
tikuta
4 years, 2 months ago (2016-09-29 08:17:39 UTC) #3
ukai
lgtm
4 years, 2 months ago (2016-09-29 08:20:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378373004/1
4 years, 2 months ago (2016-09-29 08:21:27 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/269447)
4 years, 2 months ago (2016-09-29 08:28:26 UTC) #9
Dirk Pranke
lgtm. https://codereview.chromium.org/2378373004/diff/1/build/toolchain/goma.gni File build/toolchain/goma.gni (right): https://codereview.chromium.org/2378373004/diff/1/build/toolchain/goma.gni#newcode13 build/toolchain/goma.gni:13: # Absolute directory containing the gomacc.exe. nit, maybe ...
4 years, 2 months ago (2016-09-29 17:34:08 UTC) #10
tikuta
Thank you for review. https://codereview.chromium.org/2378373004/diff/1/build/toolchain/goma.gni File build/toolchain/goma.gni (right): https://codereview.chromium.org/2378373004/diff/1/build/toolchain/goma.gni#newcode13 build/toolchain/goma.gni:13: # Absolute directory containing the ...
4 years, 2 months ago (2016-09-30 02:20:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378373004/20001
4 years, 2 months ago (2016-09-30 02:20:30 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/39662)
4 years, 2 months ago (2016-09-30 04:13:49 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378373004/40001
4 years, 2 months ago (2016-09-30 04:39:48 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-30 05:40:37 UTC) #21
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 05:43:09 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d2fb90f92170db21dabbbdb7ec38fd5252ef88a0
Cr-Commit-Position: refs/heads/master@{#422036}

Powered by Google App Engine
This is Rietveld 408576698