|
|
DescriptionUpdate comment in build/toolchain/goma.gni
BUG=651288
Committed: https://crrev.com/d2fb90f92170db21dabbbdb7ec38fd5252ef88a0
Cr-Commit-Position: refs/heads/master@{#422036}
Patch Set 1 #
Total comments: 2
Patch Set 2 : add binary #Patch Set 3 : rebase #Messages
Total messages: 23 (12 generated)
Description was changed from ========== Modify comment in build/toolchain/goma.gni BUG=651288 ========== to ========== Update comment in build/toolchain/goma.gni BUG=651288 ==========
tikuta@chromium.org changed reviewers: + dpranke@chromium.org
ukai@chromium.org changed reviewers: + ukai@chromium.org
lgtm
The CQ bit was checked by tikuta@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
lgtm. https://codereview.chromium.org/2378373004/diff/1/build/toolchain/goma.gni File build/toolchain/goma.gni (right): https://codereview.chromium.org/2378373004/diff/1/build/toolchain/goma.gni#ne... build/toolchain/goma.gni:13: # Absolute directory containing the gomacc.exe. nit, maybe 'gomacc.exe binary' here and 'gomacc' binary, below?
Thank you for review. https://codereview.chromium.org/2378373004/diff/1/build/toolchain/goma.gni File build/toolchain/goma.gni (right): https://codereview.chromium.org/2378373004/diff/1/build/toolchain/goma.gni#ne... build/toolchain/goma.gni:13: # Absolute directory containing the gomacc.exe. On 2016/09/29 17:34:08, Dirk Pranke wrote: > nit, maybe 'gomacc.exe binary' here and 'gomacc' binary, below? Done.
The CQ bit was checked by tikuta@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org, ukai@chromium.org Link to the patchset: https://codereview.chromium.org/2378373004/#ps20001 (title: "add binary")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by tikuta@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org, ukai@chromium.org Link to the patchset: https://codereview.chromium.org/2378373004/#ps40001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Update comment in build/toolchain/goma.gni BUG=651288 ========== to ========== Update comment in build/toolchain/goma.gni BUG=651288 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Update comment in build/toolchain/goma.gni BUG=651288 ========== to ========== Update comment in build/toolchain/goma.gni BUG=651288 Committed: https://crrev.com/d2fb90f92170db21dabbbdb7ec38fd5252ef88a0 Cr-Commit-Position: refs/heads/master@{#422036} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/d2fb90f92170db21dabbbdb7ec38fd5252ef88a0 Cr-Commit-Position: refs/heads/master@{#422036} |