Issue 2378353002: [Merge-M54] Fix crash on item drag in shelf.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2378353002: [Merge-M54] Fix crash on item drag in shelf. (Closed)

Created:
4 years, 2 months ago by khmel

Modified:
4 years, 2 months ago

Reviewers:
reviewer

CC:
chromium-reviews, kalyank, sadrul

Target Ref:
refs/pending/branch-heads/2840

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Merge-M54] Fix crash on item drag in shelf. This handles the case when app list sync model may contain the same ordinals for different items (which is valid case). BUG=b/31708401 BUG=647855 BUG=629624 TEST=Manually on device TEST=Extended unit_tests TBR=reviewer@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2366073002 Cr-Commit-Position: refs/heads/master@{#420944}

Patch Set 1 #

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+73 lines, -13 lines)			Patch
M	chrome/browser/ui/ash/chrome_launcher_prefs.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/ash/chrome_launcher_prefs.cc	View	2 chunks	+16 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc	View	1 chunk	+50 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378353002/1

4 years, 2 months ago (2016-09-29 01:34:13 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages