chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java - Issue 2378323002: 📰 Show the Sign In promo as a separate card from the section

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java

Issue 2378323002: 📰 Show the Sign In promo as a separate card from the section (Closed)

Patch Set: fix compilation Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java

index 2387d61973f529305d2a3c652773f24b19fee224..9943c70666c2d39a9da4ca5b2f12ed49c52f2737 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java

@@ -182,4 +182,10 @@ private static void recordScore(String histogramName, float score) {

int recordedScore = Math.min((int) Math.ceil(score), 100000);

RecordHistogram.recordCustomCountHistogram(histogramName, recordedScore, 1, 100000, 50);

}

+ @Override

+ public String toString() {

+ // For debugging purposes. Displays the first 42 characters of the title.

+ return String.format("{%s, %1.42s}", getClass().getSimpleName(), mTitle);

+ }

}