Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageItem.java

Issue 2378323002: 📰 Show the Sign In promo as a separate card from the section (Closed)
Patch Set: fix compilation Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageItem.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageItem.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageItem.java
index a8ecb2eddeab47aa51801ec7f14acd0debca31ca..74d38834b1d905d3c2a5893fa73c3a7e57c00cbd 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageItem.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageItem.java
@@ -18,7 +18,7 @@
* @see NewTabPageItem#getType()
*/
@IntDef({VIEW_TYPE_ABOVE_THE_FOLD, VIEW_TYPE_HEADER, VIEW_TYPE_SNIPPET, VIEW_TYPE_SPACING,
- VIEW_TYPE_STATUS, VIEW_TYPE_PROGRESS, VIEW_TYPE_ACTION})
+ VIEW_TYPE_STATUS, VIEW_TYPE_PROGRESS, VIEW_TYPE_ACTION, VIEW_TYPE_PROMO})
@Retention(RetentionPolicy.SOURCE)
public @interface ViewType {}
@@ -71,6 +71,12 @@
public static final int VIEW_TYPE_FOOTER = 8;
/**
+ * View type for a {@link SigninPromoItem}.
+ * @see Adapter#getItemViewType(int)
+ */
+ public static final int VIEW_TYPE_PROMO = 9;
+
+ /**
* Returns the type ({@link ViewType}) of this list item. This is so we can
* distinguish between different elements that are held in a single RecyclerView holder.
*

Powered by Google App Engine
This is Rietveld 408576698