Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3089)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java

Issue 2378323002: 📰 Show the Sign In promo as a separate card from the section (Closed)
Patch Set: fix compilation Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java
index ea8db3fe5cdbe77428c90c8c520c8d6d25576c26..c0b74d9d523046ceb293611c662aebc672bdf7c2 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java
@@ -129,6 +129,9 @@ protected void onBindViewHolder() {
// Reset the transparency and translation in case a dismissed card is being recycled.
itemView.setAlpha(1f);
itemView.setTranslationX(0f);
+
+ // Make sure we use the right background.
+ updateLayoutParams();
}
@Override
@@ -236,6 +239,7 @@ private static boolean isCard(@NewTabPageItem.ViewType int type) {
case NewTabPageItem.VIEW_TYPE_SNIPPET:
case NewTabPageItem.VIEW_TYPE_STATUS:
case NewTabPageItem.VIEW_TYPE_ACTION:
+ case NewTabPageItem.VIEW_TYPE_PROMO:
return true;
case NewTabPageItem.VIEW_TYPE_ABOVE_THE_FOLD:
case NewTabPageItem.VIEW_TYPE_HEADER:
@@ -250,7 +254,7 @@ private static boolean isCard(@NewTabPageItem.ViewType int type) {
}
@DrawableRes
- private static int selectBackground(boolean hasCardAbove, boolean hasCardBelow) {
+ protected int selectBackground(boolean hasCardAbove, boolean hasCardBelow) {
if (hasCardAbove && hasCardBelow) return R.drawable.ntp_card_middle;
if (!hasCardAbove && hasCardBelow) return R.drawable.ntp_card_top;
if (hasCardAbove && !hasCardBelow) return R.drawable.ntp_card_bottom;

Powered by Google App Engine
This is Rietveld 408576698