chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java - Issue 2378323002: 📰 Show the Sign In promo as a separate card from the section

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java

Issue 2378323002: 📰 Show the Sign In promo as a separate card from the section (Closed)

Patch Set: ready for review Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java ('K') | « chrome/android/java_sources.gni ('k') | components/ntp_snippets/remote/ntp_snippets_service.cc » ('j') | components/ntp_snippets/remote/ntp_snippets_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java

diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java

index 8bb9a13e3d69ab3c5c2235b58f276fb6d3297f86..b4411c435fc2a5a6fdb37871f15bcb663fce6cf0 100644

--- a/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java

+++ b/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java

@@ -712,7 +712,7 @@ public void testChangeNotifications() {

registerCategory(suggestionsSource, KnownCategories.ARTICLES, 3);

NewTabPageAdapter adapter = spy(

new NewTabPageAdapter(new MockNewTabPageManager(suggestionsSource), null, null));

- adapter.initializeSections();

+ adapter.finishInitialization();

doNothing().when(adapter).announceItemRemoved(anyString());

// Adapter content: