chrome/android/java/res/values/dimens.xml - Issue 2378323002: 📰 Show the Sign In promo as a separate card from the section

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/values/dimens.xml

Issue 2378323002: 📰 Show the Sign In promo as a separate card from the section (Closed)

Patch Set: fix compilation Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java/res/drawable-xxxhdpi/ntp_signin_promo_card_single.9.png ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file. -->	4 found in the LICENSE file. -->

5	5

6 <resources>	6 <resources>

7 <!-- Connection info popup dimensions -->	7 <!-- Connection info popup dimensions -->

8 <dimen name="connection_info_padding_wide">24dp</dimen>	8 <dimen name="connection_info_padding_wide">24dp</dimen>

9 <dimen name="connection_info_padding_thin">16dp</dimen>	9 <dimen name="connection_info_padding_thin">16dp</dimen>

10	10

(...skipping 349 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
360 pref_autofill_field_horizontal_padding exists because TextInputLayouts have an internal	360 pref_autofill_field_horizontal_padding exists because TextInputLayouts have an internal

361 padding set.	361 padding set.

362 -->	362 -->

363 <dimen name="pref_autofill_content_spacing">12dp</dimen>	363 <dimen name="pref_autofill_content_spacing">12dp</dimen>

364 <dimen name="pref_autofill_field_horizontal_padding">4dp</dimen>	364 <dimen name="pref_autofill_field_horizontal_padding">4dp</dimen>

365 <dimen name="pref_autofill_field_top_margin">8dp</dimen>	365 <dimen name="pref_autofill_field_top_margin">8dp</dimen>

366	366

367 <!-- Dialog dimensions.	367 <!-- Dialog dimensions.

368 https://www.google.com/design/spec/components/dialogs.html#dialogs-simp le-dialogs -->	368 https://www.google.com/design/spec/components/dialogs.html#dialogs-simp le-dialogs -->

369 <dimen name="dialog_width_unit">56dp</dimen> <!-- MD dialog widths are mult iples of this. -->	369 <dimen name="dialog_width_unit">56dp</dimen> <!-- MD dialog widths are mult iples of this. -->

370	370

371 <!-- Downloads dimensions. -->	371 <!-- Downloads dimensions. -->

372 <dimen name="downloads_item_icon_size">48dp</dimen>	372 <dimen name="downloads_item_icon_size">48dp</dimen>

373 </resources>	373 </resources>

OLD	NEW