Issue 23783007: LiveEdit to mark more closure functions for re-instantiation when scope layout changes

Issue 23783007: LiveEdit to mark more closure functions for re-instantiation when scope layout changes (Closed)

Created:
7 years, 3 months ago by Peter.Rybin

Modified:
7 years, 3 months ago

Reviewers:
aandrey, Yang

CC:
v8-dev, aandrey

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

LiveEdit to mark more closure functions for re-instantiation when scope layout changes BUG=v8:2872 R=yangguo@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16868

Patch Set 2 : follow code review #

Patch Set 3 : rebase #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -59 lines)			Patch
M	src/liveedit.cc	View	1	5 chunks	+12 lines, -14 lines	0 comments	Download
M	src/liveedit-debugger.js	View	1	10 chunks	+29 lines, -23 lines	0 comments	Download
A +	test/mjsunit/debug-liveedit-4.js	View		1 chunk	+21 lines, -22 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Peter.Rybin

This is a not large change to LiveEdit internal logic.

7 years, 3 months ago (2013-09-10 13:44:14 UTC) #1

Yang

lgtm with comment https://codereview.chromium.org/23783007/diff/1/src/liveedit-debugger.js File src/liveedit-debugger.js (right): https://codereview.chromium.org/23783007/diff/1/src/liveedit-debugger.js#newcode695 src/liveedit-debugger.js:695: // For ecah old function (if ...

7 years, 3 months ago (2013-09-20 12:17:33 UTC) #3

aandrey

nits https://codereview.chromium.org/23783007/diff/1/src/liveedit-debugger.js File src/liveedit-debugger.js (right): https://codereview.chromium.org/23783007/diff/1/src/liveedit-debugger.js#newcode224 src/liveedit-debugger.js:224: // TODO(LiveEdit): take into account wether it's source_changed ...

7 years, 3 months ago (2013-09-20 12:35:21 UTC) #4

Peter.Rybin

Committed patchset #3 manually as r16868 (presubmit successful).

7 years, 3 months ago (2013-09-20 13:15:42 UTC) #5

Peter.Rybin

7 years, 3 months ago (2013-09-20 13:16:51 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/23783007/diff/1/src/liveedit-debugger.js
File src/liveedit-debugger.js (right):

https://codereview.chromium.org/23783007/diff/1/src/liveedit-debugger.js#newc...
src/liveedit-debugger.js:224: // TODO(LiveEdit): take into account wether it's
source_changed or
On 2013/09/20 12:35:21, aandrey wrote:
> wether -> whether

Done.

https://codereview.chromium.org/23783007/diff/1/src/liveedit-debugger.js#newc...
src/liveedit-debugger.js:291: // After sorting update outer_inder field using
old_index_map. Also
On 2013/09/20 12:35:21, aandrey wrote:
> outer_inder -> outer_index

Done.

https://codereview.chromium.org/23783007/diff/1/src/liveedit-debugger.js#newc...
src/liveedit-debugger.js:695: // For ecah old function (if it is not damaged)
tries to find a corresponding
On 2013/09/20 12:17:34, Yang wrote:
> For each

Done.

https://codereview.chromium.org/23783007/diff/1/src/liveedit-debugger.js#newc...
src/liveedit-debugger.js:698: // reasons for corresponence not to be found;
function with unmodified text
On 2013/09/20 12:17:34, Yang wrote:
> correspondence

Done.

https://codereview.chromium.org/23783007/diff/1/src/liveedit-debugger.js#newc...
src/liveedit-debugger.js:871: // Changes positions (including all statments) in
function.
On 2013/09/20 12:35:21, aandrey wrote:
> statments -> statements

Done.

Expand Messages | Collapse Messages