Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2378283006: Add a clang-format exception to WebInputEvent::Modifiers. (Closed)

Created:
4 years, 2 months ago by dcheng
Modified:
4 years, 2 months ago
Reviewers:
Nico
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-api_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a clang-format exception to WebInputEvent::Modifiers. build/android/gyp/java_cpp_enum.py gets confused when clang-format wraps the excessively long line. BUG=652018 R=thakis@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/b6ae86a409be490daa69803c62dcd0d6bee7b303

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M third_party/WebKit/public/platform/WebInputEvent.h View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Nico
lgtm
4 years, 2 months ago (2016-10-01 00:52:09 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b6ae86a409be490daa69803c62dcd0d6bee7b303 Cr-Commit-Position: refs/heads/master@{#422258}
4 years, 2 months ago (2016-10-01 01:00:32 UTC) #4
dcheng
Committed patchset #1 (id:1) manually as b6ae86a409be490daa69803c62dcd0d6bee7b303 (tree was closed).
4 years, 2 months ago (2016-10-01 01:01:41 UTC) #6
estevenson
4 years, 2 months ago (2016-10-05 15:11:23 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2393183002/ by estevenson@chromium.org.

The reason for reverting is: crbug/652018 is fixed;
build/android/gyp/java_cpp_enum.py handles multi-line enum entries so the
clang-format exception is no longer necessary. .

Powered by Google App Engine
This is Rietveld 408576698