Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: Source/core/html/shadow/SliderThumbElement.cpp

Issue 237823002: Properly shrink stretched flexbox children on relayout (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix remaining computeLogicalHeight methods Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/shadow/SliderThumbElement.cpp
diff --git a/Source/core/html/shadow/SliderThumbElement.cpp b/Source/core/html/shadow/SliderThumbElement.cpp
index 093f36cc057f5f825545647822edcc3d8cd039a1..ada6d067ec547e96ee8644ab403841445f86faa6 100644
--- a/Source/core/html/shadow/SliderThumbElement.cpp
+++ b/Source/core/html/shadow/SliderThumbElement.cpp
@@ -128,11 +128,18 @@ void RenderSliderContainer::computeLogicalHeight(LayoutUnit logicalHeight, Layou
if (zoomFactor != 1.0)
trackHeight *= zoomFactor;
+ // FIXME: This height should have been added in before we got here to avoid this hack.
ojan 2014/04/17 20:01:33 These comments are not totally clear to me. I thin
+ updateIntrinsicContentLogicalHeight(trackHeight);
+
RenderBox::computeLogicalHeight(trackHeight, logicalTop, computedValues);
return;
}
if (isVertical)
logicalHeight = RenderSlider::defaultTrackLength;
+
+ // FIXME: This height should have been added in before we got here to avoid this hack.
+ updateIntrinsicContentLogicalHeight(logicalHeight);
+
RenderBox::computeLogicalHeight(logicalHeight, logicalTop, computedValues);
}
« no previous file with comments | « LayoutTests/css3/flexbox/stretched-child-shrink-on-relayout-expected.txt ('k') | Source/core/rendering/RenderBox.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698