Chromium Code Reviews| Index: Source/core/rendering/RenderTextControl.cpp |
| diff --git a/Source/core/rendering/RenderTextControl.cpp b/Source/core/rendering/RenderTextControl.cpp |
| index 690a1c43c11763477ca478f40b6409d78f4a3bd6..3673989ca6206bb5adadb40b36de2317bab68ca7 100644 |
| --- a/Source/core/rendering/RenderTextControl.cpp |
| +++ b/Source/core/rendering/RenderTextControl.cpp |
| @@ -132,12 +132,18 @@ void RenderTextControl::computeLogicalHeight(LayoutUnit logicalHeight, LayoutUni |
| ASSERT(innerText); |
| if (RenderBox* innerTextBox = innerText->renderBox()) { |
| LayoutUnit nonContentHeight = innerTextBox->borderAndPaddingHeight() + innerTextBox->marginHeight(); |
| - logicalHeight = computeControlLogicalHeight(innerTextBox->lineHeight(true, HorizontalLine, PositionOfInteriorLineBoxes), nonContentHeight) + borderAndPaddingHeight(); |
| + logicalHeight = computeControlLogicalHeight(innerTextBox->lineHeight(true, HorizontalLine, PositionOfInteriorLineBoxes), nonContentHeight); |
| // We are able to have a horizontal scrollbar if the overflow style is scroll, or if its auto and there's no word wrap. |
| if ((isHorizontalWritingMode() && (style()->overflowX() == OSCROLL || (style()->overflowX() == OAUTO && innerText->renderer()->style()->overflowWrap() == NormalOverflowWrap))) |
| || (!isHorizontalWritingMode() && (style()->overflowY() == OSCROLL || (style()->overflowY() == OAUTO && innerText->renderer()->style()->overflowWrap() == NormalOverflowWrap)))) |
| logicalHeight += scrollbarThickness(); |
| + |
| + // FIXME: The logical height of the inner text box should have been added before calling computeLogicalHeight to |
| + // avoid this hack. |
| + updateIntrinsicContentLogicalHeight(logicalHeight); |
| + |
| + logicalHeight += borderAndPaddingHeight(); |
|
ojan
2014/04/15 01:07:30
extra space
leviw_travelin_and_unemployed
2014/04/15 06:53:38
Thanks!
|
| } |
| RenderBox::computeLogicalHeight(logicalHeight, logicalTop, computedValues); |