Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 2378223002: Roll buildtools forward and fix GN build for it. (Closed)

Created:
4 years, 2 months ago by zra
Modified:
4 years, 2 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -9 lines) Patch
M DEPS View 2 chunks +2 lines, -2 lines 0 comments Download
M build/config/android/config.gni View 1 chunk +1 line, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 2 chunks +9 lines, -0 lines 0 comments Download
M build/toolchain/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M build/toolchain/gcc_toolchain.gni View 2 chunks +2 lines, -2 lines 0 comments Download
M build/toolchain/mac/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M build/toolchain/win/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
4 years, 2 months ago (2016-09-28 19:57:03 UTC) #2
Cutch
lgtm
4 years, 2 months ago (2016-09-28 19:58:45 UTC) #3
zra
4 years, 2 months ago (2016-09-28 20:03:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3b6f3f396971d5c7f7db23fff283037947daf67a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698