Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: url/gurl_unittest.cc

Issue 2378213002: Mark URLs with empty schemes as invalid. (Closed)
Patch Set: Comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/url_formatter/url_fixer_unittest.cc ('k') | url/url_canon_etc.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: url/gurl_unittest.cc
diff --git a/url/gurl_unittest.cc b/url/gurl_unittest.cc
index 1a0987edcb348f5658e5d58f7fdccb40b9141993..6bfba708b9743e9b270d95cab25aa64884a99bae 100644
--- a/url/gurl_unittest.cc
+++ b/url/gurl_unittest.cc
@@ -232,7 +232,6 @@ TEST(GURLTest, IsValid) {
"http://user:pass@google.com:12345/path?k=v#fragment",
"http:/path",
"http:path",
- "://google.com",
};
for (size_t i = 0; i < arraysize(valid_cases); i++) {
EXPECT_TRUE(GURL(valid_cases[i]).is_valid())
@@ -244,6 +243,7 @@ TEST(GURLTest, IsValid) {
"http:://google.com",
"http//google.com",
"http://google.com:12three45",
+ "://google.com",
"path",
};
for (size_t i = 0; i < arraysize(invalid_cases); i++) {
« no previous file with comments | « components/url_formatter/url_fixer_unittest.cc ('k') | url/url_canon_etc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698