components/omnibox/browser/autocomplete_input_unittest.cc - Issue 2378213002: Mark URLs with empty schemes as invalid.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/browser/autocomplete_input_unittest.cc

Issue 2378213002: Mark URLs with empty schemes as invalid. (Closed)

Patch Set: Comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/omnibox/browser/autocomplete_input_unittest.cc

diff --git a/components/omnibox/browser/autocomplete_input_unittest.cc b/components/omnibox/browser/autocomplete_input_unittest.cc

index 029695867df5fac7cc592dda1676f9861f68fa54..9a632d593e58b7ea01952199a439412bbc6b69c7 100644

--- a/components/omnibox/browser/autocomplete_input_unittest.cc

+++ b/components/omnibox/browser/autocomplete_input_unittest.cc

@@ -161,8 +161,8 @@ TEST(AutocompleteInputTest, InputType) {

{ ASCIIToUTF16("chrome-search://"), metrics::OmniboxInputType::QUERY },

{ ASCIIToUTF16("chrome-devtools:"), metrics::OmniboxInputType::QUERY },

{ ASCIIToUTF16("about://f;"), metrics::OmniboxInputType::QUERY },

- { ASCIIToUTF16("://w"), metrics::OmniboxInputType::QUERY },

- { ASCIIToUTF16(":w"), metrics::OmniboxInputType::QUERY },

+ { ASCIIToUTF16("://w"), metrics::OmniboxInputType::UNKNOWN },

+ { ASCIIToUTF16(":w"), metrics::OmniboxInputType::UNKNOWN },

{ base::WideToUTF16(L".\u062A"), metrics::OmniboxInputType::UNKNOWN },

};