Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: url/url_canon_etc.cc

Issue 2378213002: Mark URLs with empty schemes as invalid. (Closed)
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/url_formatter/url_fixer.cc ('K') | « url/gurl_unittest.cc ('k') | url/url_canon_unittest.cc » ('j') | url/url_canon_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: url/url_canon_etc.cc
diff --git a/url/url_canon_etc.cc b/url/url_canon_etc.cc
index e9da94cca39061c2daf0b7d076993657613ecc6b..9dd40da1624834ea9a3c38b2a5b9c9f6cac31b6b 100644
--- a/url/url_canon_etc.cc
+++ b/url/url_canon_etc.cc
@@ -89,7 +89,7 @@ bool DoScheme(const CHAR* spec,
// Scheme is unspecified or empty, convert to empty by appending a colon.
*out_scheme = Component(output->length(), 0);
output->push_back(':');
Peter Kasting 2016/09/29 04:54:12 What happens if we don't bother to insert a colon?
- return true;
+ return false;
}
// The output scheme starts from the current position.
« components/url_formatter/url_fixer.cc ('K') | « url/gurl_unittest.cc ('k') | url/url_canon_unittest.cc » ('j') | url/url_canon_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698