Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 2378183002: DevTools: console.dirxml() stops using XML format for array entries (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/console/console-dirxml-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 3 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
4 * Copyright (C) 2009 Joseph Pecoraro 4 * Copyright (C) 2009 Joseph Pecoraro
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 687 matching lines...) Expand 10 before | Expand all | Expand 10 after
698 section.enableContextMenu(); 698 section.enableContextMenu();
699 elem.appendChild(section.element); 699 elem.appendChild(section.element);
700 }, 700 },
701 701
702 /** 702 /**
703 * @param {!WebInspector.RemoteObject} output 703 * @param {!WebInspector.RemoteObject} output
704 * @return {!Element} 704 * @return {!Element}
705 */ 705 */
706 _formatAsArrayEntry: function(output) 706 _formatAsArrayEntry: function(output)
707 { 707 {
708 if (this._message.type === WebInspector.ConsoleMessage.MessageType.DirXM L) {
709 // Prevent infinite expansion of cross-referencing arrays.
710 return this._formatParameter(output, output.subtype === "array" || o utput.subtype === "typedarray", false);
711 }
712 return this._previewFormatter.renderPropertyPreview(output.type, output. subtype, output.description); 708 return this._previewFormatter.renderPropertyPreview(output.type, output. subtype, output.description);
713 }, 709 },
714 710
715 /** 711 /**
716 * @param {?WebInspector.RemoteObject} object 712 * @param {?WebInspector.RemoteObject} object
717 * @param {!Array.<string>} propertyPath 713 * @param {!Array.<string>} propertyPath
718 * @param {boolean} isArrayEntry 714 * @param {boolean} isArrayEntry
719 * @return {!Element} 715 * @return {!Element}
720 */ 716 */
721 _formatAsAccessorProperty: function(object, propertyPath, isArrayEntry) 717 _formatAsAccessorProperty: function(object, propertyPath, isArrayEntry)
(...skipping 512 matching lines...) Expand 10 before | Expand all | Expand 10 after
1234 { 1230 {
1235 if (!this._element) { 1231 if (!this._element) {
1236 WebInspector.ConsoleViewMessage.prototype.toMessageElement.call(this ); 1232 WebInspector.ConsoleViewMessage.prototype.toMessageElement.call(this );
1237 this._element.classList.toggle("collapsed", this._collapsed); 1233 this._element.classList.toggle("collapsed", this._collapsed);
1238 } 1234 }
1239 return this._element; 1235 return this._element;
1240 }, 1236 },
1241 1237
1242 __proto__: WebInspector.ConsoleViewMessage.prototype 1238 __proto__: WebInspector.ConsoleViewMessage.prototype
1243 } 1239 }
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/console/console-dirxml-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698