Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2378183002: DevTools: console.dirxml() stops using XML format for array entries (Closed)

Created:
4 years, 2 months ago by luoe
Modified:
4 years, 2 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: console.dirxml() stops using XML format for array entries Using console.dirxml() on an array of elements will no longer use XML formatting for the array entries when collapsed. E.g. "[<span>...</span>]" >> "[span]". This is identical to the formatting used today for evaluated results in console. BUG=607682 Committed: https://crrev.com/144fcc80829114973858a506aa38633bf63ef6d7 Cr-Commit-Position: refs/heads/master@{#421709}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M third_party/WebKit/LayoutTests/inspector/console/console-dirxml-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
luoe
4 years, 2 months ago (2016-09-28 19:10:06 UTC) #4
lushnikov
lgtm
4 years, 2 months ago (2016-09-28 19:13:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378183002/1
4 years, 2 months ago (2016-09-29 01:39:27 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 01:47:20 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 01:51:53 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/144fcc80829114973858a506aa38633bf63ef6d7
Cr-Commit-Position: refs/heads/master@{#421709}

Powered by Google App Engine
This is Rietveld 408576698