Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2378173002: Precache per-resource cap should be applied on network bytes used (Closed)

Created:
4 years, 2 months ago by Raj
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, wifiprefetch-reviews_google.com, sync-reviews_chromium.org
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Precache per-resource cap should be applied on network bytes used Currently precache fetches are cancelled when response length reaches the per-resource limit. This is incorrect for gzipped resources. BUG=625270 Review-Url: https://codereview.chromium.org/2303653002 Cr-Commit-Position: refs/heads/master@{#421101} (cherry picked from commit dc12c3dfd755611528561c6e48dec23ae59dea5f) Committed: https://chromium.googlesource.com/chromium/src/+/9db9657f57cad43fd011f96cf855b7f4da37c362

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -51 lines) Patch
M chrome/browser/extensions/api/image_writer_private/write_from_url_operation.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/image_writer_private/write_from_url_operation.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/policy/core/common/cloud/component_cloud_policy_updater_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/policy/core/common/cloud/external_policy_data_fetcher.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/policy/core/common/cloud/external_policy_data_fetcher.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/policy/core/common/cloud/external_policy_data_fetcher_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M components/policy/core/common/cloud/external_policy_data_updater_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M components/precache/core/fetcher_pool_unittest.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M components/precache/core/precache_fetcher.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/precache/core/precache_fetcher.cc View 1 chunk +8 lines, -6 lines 0 comments Download
M components/search_provider_logos/logo_tracker.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/search_provider_logos/logo_tracker.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/sync/core/http_bridge.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/sync/core/http_bridge.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/update_client/url_fetcher_downloader.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/update_client/url_fetcher_downloader.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/speech/speech_recognition_engine.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/speech/speech_recognition_engine.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/speech/speech_recognition_engine_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/test/mock_google_streaming_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/drive/base_requests.h View 1 chunk +2 lines, -1 line 0 comments Download
M google_apis/drive/base_requests.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/tools/get_server_time/get_server_time.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/url_request/test_url_fetcher_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_fetcher_core.h View 1 chunk +4 lines, -2 lines 0 comments Download
M net/url_request/url_fetcher_core.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M net/url_request/url_fetcher_delegate.h View 1 chunk +4 lines, -1 line 0 comments Download
M net/url_request/url_fetcher_delegate.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M net/url_request/url_fetcher_impl_unittest.cc View 3 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Raj
4 years, 2 months ago (2016-09-28 18:37:54 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9db9657f57cad43fd011f96cf855b7f4da37c362.

Powered by Google App Engine
This is Rietveld 408576698